netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>
Subject: Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)
Date: Wed, 12 May 2021 22:21:08 +0200	[thread overview]
Message-ID: <e11480b2-a057-9621-74ba-6e3e4fc1b306@iogearbox.net> (raw)
In-Reply-To: <751025d2-9c46-a4b9-4f54-fbe5fa7a2564@infradead.org>

On 5/12/21 9:26 PM, Randy Dunlap wrote:
> On 5/12/21 11:53 AM, Daniel Borkmann wrote:
>> On 5/12/21 8:01 PM, Randy Dunlap wrote:
>>> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>>> on i386:
>>>
>>> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
>>> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
>>> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
>>> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
>>> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
>>> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
>>> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
>>> ld: kernel/extable.o: in function `search_exception_tables':
>>> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
>>> ld: kernel/extable.o: in function `kernel_text_address':
>>> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
>>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
>>> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
>>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
>>> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'
>>
>> Thanks for reporting, could you double check the following diff:
>>
>> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
>> index 26b591e23f16..bd04f4a44c01 100644
>> --- a/kernel/bpf/Kconfig
>> +++ b/kernel/bpf/Kconfig
>> @@ -37,6 +37,7 @@ config BPF_SYSCALL
>>
>> config BPF_JIT
>>      bool "Enable BPF Just In Time compiler"
>> +    depends on BPF
>>      depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
>>      depends on MODULES
>>      help
> 
> That's good. Thanks.

Thanks, pushed fix to bpf tree.

      reply	other threads:[~2021-05-12 21:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210512175623.2687ac6f@canb.auug.org.au>
2021-05-12 18:01 ` linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o) Randy Dunlap
2021-05-12 18:53   ` Daniel Borkmann
2021-05-12 19:26     ` Randy Dunlap
2021-05-12 20:21       ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e11480b2-a057-9621-74ba-6e3e4fc1b306@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).