netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)
       [not found] <20210512175623.2687ac6f@canb.auug.org.au>
@ 2021-05-12 18:01 ` Randy Dunlap
  2021-05-12 18:53   ` Daniel Borkmann
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-05-12 18:01 UTC (permalink / raw)
  To: Stephen Rothwell, Linux Next Mailing List, Alexei Starovoitov,
	Daniel Borkmann, Andrii Nakryiko
  Cc: Linux Kernel Mailing List, netdev, bpf

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On 5/12/21 12:56 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20210511:
> 

on i386:

ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
ld: kernel/extable.o: in function `search_exception_tables':
extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
ld: kernel/extable.o: in function `kernel_text_address':
extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'


Full randconfig file is attached.


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>


[-- Attachment #2: config-r9260.gz --]
[-- Type: application/gzip, Size: 45092 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)
  2021-05-12 18:01 ` linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o) Randy Dunlap
@ 2021-05-12 18:53   ` Daniel Borkmann
  2021-05-12 19:26     ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2021-05-12 18:53 UTC (permalink / raw)
  To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
	Alexei Starovoitov, Andrii Nakryiko
  Cc: Linux Kernel Mailing List, netdev, bpf

Hi Randy,

On 5/12/21 8:01 PM, Randy Dunlap wrote:
> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20210511:
>>
> 
> on i386:
> 
> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
> ld: kernel/extable.o: in function `search_exception_tables':
> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
> ld: kernel/extable.o: in function `kernel_text_address':
> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'

Thanks for reporting, could you double check the following diff:

diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
index 26b591e23f16..bd04f4a44c01 100644
--- a/kernel/bpf/Kconfig
+++ b/kernel/bpf/Kconfig
@@ -37,6 +37,7 @@ config BPF_SYSCALL

  config BPF_JIT
  	bool "Enable BPF Just In Time compiler"
+	depends on BPF
  	depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
  	depends on MODULES
  	help

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)
  2021-05-12 18:53   ` Daniel Borkmann
@ 2021-05-12 19:26     ` Randy Dunlap
  2021-05-12 20:21       ` Daniel Borkmann
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-05-12 19:26 UTC (permalink / raw)
  To: Daniel Borkmann, Stephen Rothwell, Linux Next Mailing List,
	Alexei Starovoitov, Andrii Nakryiko
  Cc: Linux Kernel Mailing List, netdev, bpf

On 5/12/21 11:53 AM, Daniel Borkmann wrote:
> Hi Randy,
> 
> On 5/12/21 8:01 PM, Randy Dunlap wrote:
>> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210511:
>>>
>>
>> on i386:
>>
>> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
>> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
>> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
>> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
>> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
>> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
>> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
>> ld: kernel/extable.o: in function `search_exception_tables':
>> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
>> ld: kernel/extable.o: in function `kernel_text_address':
>> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
>> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
>> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'
> 
> Thanks for reporting, could you double check the following diff:
> 
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index 26b591e23f16..bd04f4a44c01 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -37,6 +37,7 @@ config BPF_SYSCALL
> 
> config BPF_JIT
>     bool "Enable BPF Just In Time compiler"
> +    depends on BPF
>     depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
>     depends on MODULES
>     help

That's good. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


-- 
~Randy


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o)
  2021-05-12 19:26     ` Randy Dunlap
@ 2021-05-12 20:21       ` Daniel Borkmann
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2021-05-12 20:21 UTC (permalink / raw)
  To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
	Alexei Starovoitov, Andrii Nakryiko
  Cc: Linux Kernel Mailing List, netdev, bpf

On 5/12/21 9:26 PM, Randy Dunlap wrote:
> On 5/12/21 11:53 AM, Daniel Borkmann wrote:
>> On 5/12/21 8:01 PM, Randy Dunlap wrote:
>>> On 5/12/21 12:56 AM, Stephen Rothwell wrote:
>>> on i386:
>>>
>>> ld: arch/x86/net/bpf_jit_comp32.o: in function `do_jit':
>>> bpf_jit_comp32.c:(.text+0x28c9): undefined reference to `__bpf_call_base'
>>> ld: arch/x86/net/bpf_jit_comp32.o: in function `bpf_int_jit_compile':
>>> bpf_jit_comp32.c:(.text+0x3694): undefined reference to `bpf_jit_blind_constants'
>>> ld: bpf_jit_comp32.c:(.text+0x3719): undefined reference to `bpf_jit_binary_free'
>>> ld: bpf_jit_comp32.c:(.text+0x3745): undefined reference to `bpf_jit_binary_alloc'
>>> ld: bpf_jit_comp32.c:(.text+0x37d3): undefined reference to `bpf_jit_prog_release_other'
>>> ld: kernel/extable.o: in function `search_exception_tables':
>>> extable.c:(.text+0x42): undefined reference to `search_bpf_extables'
>>> ld: kernel/extable.o: in function `kernel_text_address':
>>> extable.c:(.text+0xee): undefined reference to `is_bpf_text_address'
>>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_size_offset':
>>> kallsyms.c:(.text+0x254): undefined reference to `__bpf_address_lookup'
>>> ld: kernel/kallsyms.o: in function `kallsyms_lookup_buildid':
>>> kallsyms.c:(.text+0x2ee): undefined reference to `__bpf_address_lookup'
>>
>> Thanks for reporting, could you double check the following diff:
>>
>> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
>> index 26b591e23f16..bd04f4a44c01 100644
>> --- a/kernel/bpf/Kconfig
>> +++ b/kernel/bpf/Kconfig
>> @@ -37,6 +37,7 @@ config BPF_SYSCALL
>>
>> config BPF_JIT
>>      bool "Enable BPF Just In Time compiler"
>> +    depends on BPF
>>      depends on HAVE_CBPF_JIT || HAVE_EBPF_JIT
>>      depends on MODULES
>>      help
> 
> That's good. Thanks.

Thanks, pushed fix to bpf tree.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-12 21:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210512175623.2687ac6f@canb.auug.org.au>
2021-05-12 18:01 ` linux-next: Tree for May 12 (arch/x86/net/bpf_jit_comp32.o) Randy Dunlap
2021-05-12 18:53   ` Daniel Borkmann
2021-05-12 19:26     ` Randy Dunlap
2021-05-12 20:21       ` Daniel Borkmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).