* [PATCH] tools: bpftool: do not force gcc as CC
@ 2018-12-19 20:08 Ivan Babrou
2018-12-19 21:04 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Babrou @ 2018-12-19 20:08 UTC (permalink / raw)
To: netdev; +Cc: sdf, trivial, jolsa, jakub.kicinski, ast, daniel
This allows transparent cross-compilation with CROSS_COMPILE.
Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
---
tools/bpf/bpftool/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index dac7eff4c7e5..ee906f597f21 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -35,8 +35,6 @@ $(LIBBPF)-clean:
prefix ?= /usr/local
bash_compdir ?= /usr/share/bash-completion/completions
-CC = gcc
-
CFLAGS += -O2
CFLAGS += -W -Wall -Wextra -Wno-unused-parameter -Wshadow
-Wno-missing-field-initializers
CFLAGS += -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ \
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools: bpftool: do not force gcc as CC
2018-12-19 20:08 [PATCH] tools: bpftool: do not force gcc as CC Ivan Babrou
@ 2018-12-19 21:04 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2018-12-19 21:04 UTC (permalink / raw)
To: Ivan Babrou, netdev; +Cc: sdf, trivial, jolsa, jakub.kicinski, ast
On 12/19/2018 09:08 PM, Ivan Babrou wrote:
> This allows transparent cross-compilation with CROSS_COMPILE.
>
> Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
Looks good, applied! So we basically piggy back on 7ed1c1901fe5 ("tools:
fix cross-compile var clobbering") which moved everything to the
tools/scripts/Makefile.include which bpftool includes. Could we
then also reduce tools/lib/bpf/Makefile as well for cross-compilation?
Looks like this has bunch of duplicate logic and yet we pull in the
Makefile.include as well there.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-19 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 20:08 [PATCH] tools: bpftool: do not force gcc as CC Ivan Babrou
2018-12-19 21:04 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).