* Re: [PATCH net-next] net: phy: modify assignment to OR for dev_flags in phy_attach_direct
[not found] <20190805185551.3140564-1-taoren@fb.com>
@ 2019-08-06 21:11 ` Andrew Lunn
2019-08-13 19:54 ` Florian Fainelli
1 sibling, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2019-08-06 21:11 UTC (permalink / raw)
To: Tao Ren
Cc: Florian Fainelli, Heiner Kallweit, David S . Miller,
Vladimir Oltean, Arun Parameswaran, Justin Chen, netdev,
linux-kernel, openbmc
On Mon, Aug 05, 2019 at 11:55:51AM -0700, Tao Ren wrote:
> Modify the assignment to OR when dealing with phydev->dev_flags in
> phy_attach_direct function, and this is to make sure dev_flags set in
> driver's probe callback won't be lost.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> CC: Heiner Kallweit <hkallweit1@gmail.com>
> CC: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Tao Ren <taoren@fb.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: phy: modify assignment to OR for dev_flags in phy_attach_direct
[not found] <20190805185551.3140564-1-taoren@fb.com>
2019-08-06 21:11 ` [PATCH net-next] net: phy: modify assignment to OR for dev_flags in phy_attach_direct Andrew Lunn
@ 2019-08-13 19:54 ` Florian Fainelli
1 sibling, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2019-08-13 19:54 UTC (permalink / raw)
To: Tao Ren, Andrew Lunn, Heiner Kallweit, David S . Miller,
Vladimir Oltean, Arun Parameswaran, Justin Chen, netdev,
linux-kernel, openbmc
On 8/5/19 11:55 AM, Tao Ren wrote:
> Modify the assignment to OR when dealing with phydev->dev_flags in
> phy_attach_direct function, and this is to make sure dev_flags set in
> driver's probe callback won't be lost.
As Andrew pointed out already, this probably needs to be reworked, but
for now this looks reasonable:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread