From: <Arun.Ramadoss@microchip.com>
To: <andrew@lunn.ch>, <linux-kernel@vger.kernel.org>,
<linux@armlinux.org.uk>, <Divya.Koppera@microchip.com>,
<kuba@kernel.org>, <edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <netdev@vger.kernel.org>,
<alexanderduyck@fb.com>, <davem@davemloft.net>,
<hkallweit1@gmail.com>
Cc: <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
Date: Fri, 6 Jan 2023 09:17:09 +0000 [thread overview]
Message-ID: <f83c935d99927bb23056760b04115296e6ade7de.camel@microchip.com> (raw)
In-Reply-To: <20230106082905.1159-2-Divya.Koppera@microchip.com>
Hi Divya,
On Fri, 2023-01-06 at 13:59 +0530, Divya Koppera wrote:
> Initialized return variable
>
> Fixes Old smatch warnings:
> drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> uninitialized symbol 'ret'.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
I think, Reviewed-by tag should come after signed-off tag. It should be
in chronological order.
next prev parent reply other threads:[~2023-01-06 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 8:29 [PATCH v6 net-next 0/2] Fixed warnings Divya Koppera
2023-01-06 8:29 ` [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
2023-01-06 9:17 ` Arun.Ramadoss [this message]
2023-01-06 8:29 ` [PATCH v6 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Divya Koppera
2023-01-09 7:30 ` [PATCH v6 net-next 0/2] Fixed warnings patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83c935d99927bb23056760b04115296e6ade7de.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).