* [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff()
@ 2019-07-17 6:29 Wei Yongjun
2019-07-17 17:58 ` Vladimir Oltean
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Wei Yongjun @ 2019-07-17 6:29 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean
Cc: Wei Yongjun, netdev, kernel-janitors
Add the missing unlock before return from function sk_buff()
in the error handling case.
Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX timestamping")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/dsa/tag_sja1105.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
index 1d96c9d4a8e9..26363d72d25b 100644
--- a/net/dsa/tag_sja1105.c
+++ b/net/dsa/tag_sja1105.c
@@ -216,6 +216,7 @@ static struct sk_buff
if (!skb) {
dev_err_ratelimited(dp->ds->dev,
"Failed to copy stampable skb\n");
+ spin_unlock(&sp->data->meta_lock);
return NULL;
}
sja1105_transfer_meta(skb, meta);
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff()
2019-07-17 6:29 [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff() Wei Yongjun
@ 2019-07-17 17:58 ` Vladimir Oltean
2019-07-18 16:42 ` Vivien Didelot
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Vladimir Oltean @ 2019-07-17 17:58 UTC (permalink / raw)
To: Wei Yongjun
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, netdev, kernel-janitors
On Wed, 17 Jul 2019 at 09:24, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX timestamping")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> net/dsa/tag_sja1105.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
> index 1d96c9d4a8e9..26363d72d25b 100644
> --- a/net/dsa/tag_sja1105.c
> +++ b/net/dsa/tag_sja1105.c
> @@ -216,6 +216,7 @@ static struct sk_buff
> if (!skb) {
> dev_err_ratelimited(dp->ds->dev,
> "Failed to copy stampable skb\n");
> + spin_unlock(&sp->data->meta_lock);
> return NULL;
> }
> sja1105_transfer_meta(skb, meta);
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff()
2019-07-17 6:29 [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff() Wei Yongjun
2019-07-17 17:58 ` Vladimir Oltean
@ 2019-07-18 16:42 ` Vivien Didelot
2019-07-18 17:24 ` Florian Fainelli
2019-07-18 23:33 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Vivien Didelot @ 2019-07-18 16:42 UTC (permalink / raw)
To: Wei Yongjun
Cc: Andrew Lunn, Florian Fainelli, Vladimir Oltean, Wei Yongjun,
netdev, kernel-janitors
On Wed, 17 Jul 2019 06:29:56 +0000, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX timestamping")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff()
2019-07-17 6:29 [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff() Wei Yongjun
2019-07-17 17:58 ` Vladimir Oltean
2019-07-18 16:42 ` Vivien Didelot
@ 2019-07-18 17:24 ` Florian Fainelli
2019-07-18 23:33 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2019-07-18 17:24 UTC (permalink / raw)
To: Wei Yongjun, Andrew Lunn, Vivien Didelot, Vladimir Oltean
Cc: netdev, kernel-janitors
On 7/16/19 11:29 PM, Wei Yongjun wrote:
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX timestamping")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff()
2019-07-17 6:29 [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff() Wei Yongjun
` (2 preceding siblings ...)
2019-07-18 17:24 ` Florian Fainelli
@ 2019-07-18 23:33 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2019-07-18 23:33 UTC (permalink / raw)
To: weiyongjun1
Cc: andrew, vivien.didelot, f.fainelli, olteanv, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 17 Jul 2019 06:29:56 +0000
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX timestamping")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-18 23:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 6:29 [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff() Wei Yongjun
2019-07-17 17:58 ` Vladimir Oltean
2019-07-18 16:42 ` Vivien Didelot
2019-07-18 17:24 ` Florian Fainelli
2019-07-18 23:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).