* [PATCH net-next v3] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
@ 2020-07-20 7:56 Wang Hai
2020-07-20 9:23 ` Shay Agroskin
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-07-20 7:56 UTC (permalink / raw)
To: joe, shayagr, gtzalik, saeedb, zorik, davem, kuba, sameehj
Cc: netdev, linux-kernel
Fix sparse build warning:
drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
Using plain integer as NULL pointer
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Suggested-by: Joe Perches <joe@perches.com>
Acked-by: Shay Agroskin <shayagr@amazon.com>
---
v1->v2:
Improve code readability based on Joe Perches's suggestion
v2->v3:
Simplify code based on Joe Perches's suggestion
drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 91be3ffa1c5c..3eb63b12dd68 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter,
static void ena_init_napi_in_range(struct ena_adapter *adapter,
int first_index, int count)
{
- struct ena_napi *napi = {0};
int i;
for (i = first_index; i < first_index + count; i++) {
- napi = &adapter->ena_napi[i];
+ struct ena_napi *napi = &adapter->ena_napi[i];
netif_napi_add(adapter->netdev,
- &adapter->ena_napi[i].napi,
+ &napi->napi,
ENA_IS_XDP_INDEX(adapter, i) ? ena_xdp_io_poll : ena_io_poll,
ENA_NAPI_BUDGET);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v3] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
2020-07-20 7:56 [PATCH net-next v3] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range Wang Hai
@ 2020-07-20 9:23 ` Shay Agroskin
0 siblings, 0 replies; 2+ messages in thread
From: Shay Agroskin @ 2020-07-20 9:23 UTC (permalink / raw)
To: Wang Hai
Cc: joe, gtzalik, saeedb, zorik, davem, kuba, sameehj, netdev, linux-kernel
Wang Hai <wanghai38@huawei.com> writes:
> Fix sparse build warning:
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
> Using plain integer as NULL pointer
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> Suggested-by: Joe Perches <joe@perches.com>
> Acked-by: Shay Agroskin <shayagr@amazon.com>
> ---
> v1->v2:
> Improve code readability based on Joe Perches's suggestion
> v2->v3:
> Simplify code based on Joe Perches's suggestion
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 91be3ffa1c5c..3eb63b12dd68 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -2190,14 +2190,13 @@ static void ena_del_napi_in_range(struct
> ena_adapter *adapter,
> static void ena_init_napi_in_range(struct ena_adapter *adapter,
> int first_index, int count)
> {
> - struct ena_napi *napi = {0};
> int i;
>
> for (i = first_index; i < first_index + count; i++) {
> - napi = &adapter->ena_napi[i];
> + struct ena_napi *napi = &adapter->ena_napi[i];
>
> netif_napi_add(adapter->netdev,
> - &adapter->ena_napi[i].napi,
> + &napi->napi,
> ENA_IS_XDP_INDEX(adapter, i) ?
> ena_xdp_io_poll : ena_io_poll,
> ENA_NAPI_BUDGET);
Acked-by: Shay Agroskin <shayagr@amazon.com>
Thanks a lot for your work
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-20 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 7:56 [PATCH net-next v3] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range Wang Hai
2020-07-20 9:23 ` Shay Agroskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).