netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: David Miller <davem@davemloft.net>
Cc: mlindner@marvell.com, stephen@networkplumber.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	swm@swm1.com
Subject: Re: [PATCH] sky2: Disable MSI on yet another ASUS boards (P6Xxxx)
Date: Thu, 29 Aug 2019 07:20:44 +0200	[thread overview]
Message-ID: <s5hsgpkmtsj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190828.160937.1788181909547435040.davem@davemloft.net>

On Thu, 29 Aug 2019 01:09:37 +0200,
David Miller wrote:
> 
> From: Takashi Iwai <tiwai@suse.de>
> Date: Wed, 28 Aug 2019 08:31:19 +0200
> 
> > A similar workaround for the suspend/resume problem is needed for yet
> > another ASUS machines, P6X models.  Like the previous fix, the BIOS
> > doesn't provide the standard DMI_SYS_* entry, so again DMI_BOARD_*
> > entries are used instead.
> > 
> > Reported-and-tested-by: SteveM <swm@swm1.com>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> Applied, but this is getting suspicious.
> 
> It looks like MSI generally is not restored properly on resume on these
> boards, so maybe there simply needs to be a generic PCI quirk for that?

Yes, I wondered that, too.
But, e.g. HD-audio should use MSI on Intel platforms, and if the
problem were generic, it must suffer from the same issue, and I
haven't heard of such, so far.  So it's likely specific to some
limited devices, as it seems.


Thanks!

Takashi

  reply	other threads:[~2019-08-29  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  6:31 [PATCH] sky2: Disable MSI on yet another ASUS boards (P6Xxxx) Takashi Iwai
2019-08-28 23:09 ` David Miller
2019-08-29  5:20   ` Takashi Iwai [this message]
2019-08-30 21:18     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsgpkmtsj.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlindner@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=swm@swm1.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).