* Re: [PATCH] tracing: check the return value of kstrdup()
@ 2021-12-13 7:59 Xiaoke Wang
2021-12-13 16:52 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Xiaoke Wang @ 2021-12-13 7:59 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, netdev, bpf, Xiaoke Wang
Note: Compare with the last email, this one is using my full name.
And I am sorry that yesterday I did not notice the bugs in trace_boot.c had been
already patched.
kstrdup() returns NULL when some internal memory errors happen, it is
better to check the return value of it.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
kernel/trace/trace_uprobe.c | 5 +++++
1 files changed, 5 insertions(+)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 225ce56..173ff0f 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
tu->path = path;
tu->ref_ctr_offset = ref_ctr_offset;
tu->filename = kstrdup(name, GFP_KERNEL);
+ if (!tu->filename) {
+ ret = -ENOMEM;
+ goto error;
+ }
+
init_trace_event_call(tu);
ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: check the return value of kstrdup()
2021-12-13 7:59 [PATCH] tracing: check the return value of kstrdup() Xiaoke Wang
@ 2021-12-13 16:52 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2021-12-13 16:52 UTC (permalink / raw)
To: Xiaoke Wang; +Cc: mingo, linux-kernel, netdev, bpf
On Mon, 13 Dec 2021 15:59:04 +0800
Xiaoke Wang <xkernel.wang@foxmail.com> wrote:
> Note: Compare with the last email, this one is using my full name.
> And I am sorry that yesterday I did not notice the bugs in trace_boot.c had been
> already patched.
> kstrdup() returns NULL when some internal memory errors happen, it is
> better to check the return value of it.
Can you please resend this as a normal patch, and not a reply to this email
thread.
Thank you,
-- Steve
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> kernel/trace/trace_uprobe.c | 5 +++++
> 1 files changed, 5 insertions(+)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 225ce56..173ff0f 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
> tu->path = path;
> tu->ref_ctr_offset = ref_ctr_offset;
> tu->filename = kstrdup(name, GFP_KERNEL);
> + if (!tu->filename) {
> + ret = -ENOMEM;
> + goto error;
> + }
> +
> init_trace_event_call(tu);
>
> ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] tracing: check the return value of kstrdup()
@ 2021-12-12 15:36 xkernel
0 siblings, 0 replies; 3+ messages in thread
From: xkernel @ 2021-12-12 15:36 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, netdev, bpf, xkernel
kstrdup() returns NULL when some internal memory errors happen, it is
better to check the return value of it. The code is under Linux-5.15.
Signed-off-by: xkernel <xkernel.wang@foxmail.com>
---
kernel/trace/trace_boot.c | 4 ++++
kernel/trace/trace_uprobe.c | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
index 8d252f6..0580287 100644
--- a/kernel/trace/trace_boot.c
+++ b/kernel/trace/trace_boot.c
@@ -430,6 +430,8 @@ trace_boot_init_histograms(struct trace_event_file *file,
/* All digit started node should be instances. */
if (trace_boot_compose_hist_cmd(node, buf, size) == 0) {
tmp = kstrdup(buf, GFP_KERNEL);
+ if (!tmp)
+ return;
if (trigger_process_regex(file, buf) < 0)
pr_err("Failed to apply hist trigger: %s\n", tmp);
kfree(tmp);
@@ -439,6 +441,8 @@ trace_boot_init_histograms(struct trace_event_file *file,
if (xbc_node_find_subkey(hnode, "keys")) {
if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0) {
tmp = kstrdup(buf, GFP_KERNEL);
+ if (!tmp)
+ return;
if (trigger_process_regex(file, buf) < 0)
pr_err("Failed to apply hist trigger: %s\n", tmp);
kfree(tmp);
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 225ce56..173ff0f 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -1618,6 +1618,11 @@ create_local_trace_uprobe(char *name, unsigned long offs,
tu->path = path;
tu->ref_ctr_offset = ref_ctr_offset;
tu->filename = kstrdup(name, GFP_KERNEL);
+ if (!tu->filename) {
+ ret = -ENOMEM;
+ goto error;
+ }
+
init_trace_event_call(tu);
ptype = is_ret_probe(tu) ? PROBE_PRINT_RETURN : PROBE_PRINT_NORMAL;
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-13 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 7:59 [PATCH] tracing: check the return value of kstrdup() Xiaoke Wang
2021-12-13 16:52 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2021-12-12 15:36 xkernel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).