From: Edward Cree <ecree@solarflare.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
<netfilter-devel@vger.kernel.org>
Cc: <jiri@resnulli.us>, <netdev@vger.kernel.org>
Subject: Re: [PATCH nf-next] netfilter: nf_tables_offload: allow ethernet interface type only
Date: Tue, 29 Oct 2019 17:10:05 +0000 [thread overview]
Message-ID: <0a5a341a-5576-8cc5-dcf1-f9780f57fd66@solarflare.com> (raw)
In-Reply-To: <20191029104057.21894-1-pablo@netfilter.org>
On 29/10/2019 10:40, Pablo Neira Ayuso wrote:
> Hardware offload support at this stage assumes an ethernet device in
> place. The flow dissector provides the intermediate representation to
> express this selector, so extend it to allow to store the interface
> type. Flower does not uses this, so skb_flow_dissect_meta() is not
> extended to allow to match on this new field.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> @Jiri: flower ignores this when checking for the ingress device, probably
> that should restricted there too?
>
> include/net/flow_dissector.h | 2 ++
> net/netfilter/nft_cmp.c | 7 +++++++
> net/netfilter/nft_meta.c | 4 ++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
> index 5cd12276ae21..7d804db85442 100644
> --- a/include/net/flow_dissector.h
> +++ b/include/net/flow_dissector.h
> @@ -204,9 +204,11 @@ struct flow_dissector_key_ip {
> /**
> * struct flow_dissector_key_meta:
> * @ingress_ifindex: ingress ifindex
> + * @iiftype: interface type
> */
> struct flow_dissector_key_meta {
> int ingress_ifindex;
> + u16 ingress_iftype;
> };
Comment does not match code wrt name of this new member.
next prev parent reply other threads:[~2019-10-29 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 10:40 [PATCH nf-next] netfilter: nf_tables_offload: allow ethernet interface type only Pablo Neira Ayuso
2019-10-29 17:10 ` Edward Cree [this message]
2019-10-30 3:09 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a5a341a-5576-8cc5-dcf1-f9780f57fd66@solarflare.com \
--to=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).