From: wenxu <wenxu@ucloud.cn>
To: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Cc: jiri@resnulli.us, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_tables_offload: allow ethernet interface type only
Date: Wed, 30 Oct 2019 11:09:55 +0800 [thread overview]
Message-ID: <4b32ec17-d7e1-f79f-2f90-522e2c810721@ucloud.cn> (raw)
In-Reply-To: <20191029104057.21894-1-pablo@netfilter.org>
On 10/29/2019 6:40 PM, Pablo Neira Ayuso wrote:
> @@ -113,6 +114,7 @@ static int __nft_cmp_offload(struct nft_offload_ctx *ctx,
> const struct nft_cmp_expr *priv)
> {
> struct nft_offload_reg *reg = &ctx->regs[priv->sreg];
> + static u16 iftype_ether = ARPHRD_ETHER;
> u8 *mask = (u8 *)&flow->match.mask;
> u8 *key = (u8 *)&flow->match.key;
>
> @@ -125,6 +127,11 @@ static int __nft_cmp_offload(struct nft_offload_ctx *ctx,
> flow->match.dissector.used_keys |= BIT(reg->key);
> flow->match.dissector.offset[reg->key] = reg->base_offset;
>
> + if (reg->key == FLOW_DISSECTOR_KEY_META &&
> + reg->offset == offsetof(struct nft_flow_key, meta.ingress_iftype) &&
> + memcmp(&priv->data, &iftype_ether, priv->len))
Maybe it is better to check the priv->len == sizeof(u16)?
> + return -EOPNOTSUPP;
> +
> nft_offload_update_dependency(ctx, &priv->data, priv->len);
>
> return 0;
> diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
> index 8fd21f436347..6fb6a6778e68 100644
> --- a/net/netfilter/nft_meta.c
> +++ b/net/netfilter/nft_meta.c
> @@ -551,6 +551,10 @@ static int nft_meta_get_offload(struct nft_offload_ctx *ctx,
> NFT_OFFLOAD_MATCH(FLOW_DISSECTOR_KEY_META, meta,
> ingress_ifindex, sizeof(__u32), reg);
> break;
> + case NFT_META_IIFTYPE:
> + NFT_OFFLOAD_MATCH(FLOW_DISSECTOR_KEY_META, meta,
> + ingress_iftype, sizeof(__u16), reg);
> + break;
> default:
> return -EOPNOTSUPP;
> }
prev parent reply other threads:[~2019-10-30 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 10:40 [PATCH nf-next] netfilter: nf_tables_offload: allow ethernet interface type only Pablo Neira Ayuso
2019-10-29 17:10 ` Edward Cree
2019-10-30 3:09 ` wenxu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b32ec17-d7e1-f79f-2f90-522e2c810721@ucloud.cn \
--to=wenxu@ucloud.cn \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).