* [PATCH] bridge:Fix concurrent access issue in the function brnf_get_logical_dev
@ 2015-08-22 4:48 Nicholas Krause
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Krause @ 2015-08-22 4:48 UTC (permalink / raw)
To: pablo
Cc: netdev, bridge, linux-kernel, kaber, coreteam, netfilter-devel,
kadlec, davem
This fixes a concurrent access issue in the function brnf_get_logical_dev
by properly locking with the function rcu_read_lock before calling the
function vlan_find_dev_deep_rcu and unlocking after this function call
as all callers of this function are required to do this in order to
improve issues with concurrent access by other threads executing
on this data structures simultaneously.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
net/bridge/br_netfilter_hooks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index c8b9bcf..73c84a8 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -428,9 +428,10 @@ static struct net_device *brnf_get_logical_dev(struct sk_buff *skb, const struct
if (brnf_pass_vlan_indev == 0 || !skb_vlan_tag_present(skb))
return br;
+ rcu_read_lock();
vlan = __vlan_find_dev_deep_rcu(br, skb->vlan_proto,
skb_vlan_tag_get(skb) & VLAN_VID_MASK);
-
+ rcu_read_unlock();
return vlan ? vlan : br;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] bridge:Fix concurrent access issue in the function brnf_get_logical_dev
@ 2015-08-22 4:47 Nicholas Krause
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Krause @ 2015-08-22 4:47 UTC (permalink / raw)
To: pablo
Cc: kadlec, bridge, linux-kernel, davem, coreteam, netfilter-devel,
netdev, kaber
This fixes a concurrent access issue in the function brnf_get_logical_dev
by properly locking with the function rcu_read_lock before calling the
function vlan_find_dev_deep_rcu and unlocking after this function call
as all callers of this function are required to do this in order to
improve issues with concurrent access by other threads executing
on this data structures simultaneously.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
net/bridge/br_netfilter_hooks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index c8b9bcf..73c84a8 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -428,9 +428,10 @@ static struct net_device *brnf_get_logical_dev(struct sk_buff *skb, const struct
if (brnf_pass_vlan_indev == 0 || !skb_vlan_tag_present(skb))
return br;
+ rcu_read_lock();
vlan = __vlan_find_dev_deep_rcu(br, skb->vlan_proto,
skb_vlan_tag_get(skb) & VLAN_VID_MASK);
-
+ rcu_read_unlock();
return vlan ? vlan : br;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-22 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-22 4:48 [PATCH] bridge:Fix concurrent access issue in the function brnf_get_logical_dev Nicholas Krause
-- strict thread matches above, loose matches on Subject: below --
2015-08-22 4:47 Nicholas Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).