netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: subashab@codeaurora.org
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: ip6t_REJECT: Log reject reason in reject_tg6()
Date: Thu, 30 Jul 2015 13:59:07 +0200	[thread overview]
Message-ID: <20150730115907.GA7104@salvia> (raw)
In-Reply-To: <283e896df54b88cc7446fc2cde7a5df3.squirrel@www.codeaurora.org>

On Thu, Jul 30, 2015 at 02:34:13AM -0000, subashab@codeaurora.org wrote:
> The existing message is not very useful, so add the reject reason
> to help in debug.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> ---
>  net/ipv6/netfilter/ip6t_REJECT.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/netfilter/ip6t_REJECT.c
> b/net/ipv6/netfilter/ip6t_REJECT.c
> index 544b0a9..f956513 100644
> --- a/net/ipv6/netfilter/ip6t_REJECT.c
> +++ b/net/ipv6/netfilter/ip6t_REJECT.c
> @@ -42,7 +42,7 @@ reject_tg6(struct sk_buff *skb, const struct
> xt_action_param *par)
>  	const struct ip6t_reject_info *reject = par->targinfo;
>  	struct net *net = dev_net((par->in != NULL) ? par->in : par->out);
> 
> -	pr_debug("%s: medium point\n", __func__);
> +	pr_debug("%s: case %u\n", __func__, reject->with);

I'd suggest you send a patch to remove this debug message to get this
in sync with the IPv4 version of the REJECT target.

Thanks.

      reply	other threads:[~2015-07-30 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  2:34 [PATCH nf-next] netfilter: ip6t_REJECT: Log reject reason in reject_tg6() subashab
2015-07-30 11:59 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730115907.GA7104@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).