netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH nf-next] netfilter: ip6t_REJECT: Log reject reason in reject_tg6()
@ 2015-07-30  2:34 subashab
  2015-07-30 11:59 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: subashab @ 2015-07-30  2:34 UTC (permalink / raw)
  To: netfilter-devel

The existing message is not very useful, so add the reject reason
to help in debug.

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
---
 net/ipv6/netfilter/ip6t_REJECT.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/netfilter/ip6t_REJECT.c
b/net/ipv6/netfilter/ip6t_REJECT.c
index 544b0a9..f956513 100644
--- a/net/ipv6/netfilter/ip6t_REJECT.c
+++ b/net/ipv6/netfilter/ip6t_REJECT.c
@@ -42,7 +42,7 @@ reject_tg6(struct sk_buff *skb, const struct
xt_action_param *par)
 	const struct ip6t_reject_info *reject = par->targinfo;
 	struct net *net = dev_net((par->in != NULL) ? par->in : par->out);

-	pr_debug("%s: medium point\n", __func__);
+	pr_debug("%s: case %u\n", __func__, reject->with);
 	switch (reject->with) {
 	case IP6T_ICMP6_NO_ROUTE:
 		nf_send_unreach6(net, skb, ICMPV6_NOROUTE, par->hooknum);
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH nf-next] netfilter: ip6t_REJECT: Log reject reason in reject_tg6()
  2015-07-30  2:34 [PATCH nf-next] netfilter: ip6t_REJECT: Log reject reason in reject_tg6() subashab
@ 2015-07-30 11:59 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2015-07-30 11:59 UTC (permalink / raw)
  To: subashab; +Cc: netfilter-devel

On Thu, Jul 30, 2015 at 02:34:13AM -0000, subashab@codeaurora.org wrote:
> The existing message is not very useful, so add the reject reason
> to help in debug.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
> ---
>  net/ipv6/netfilter/ip6t_REJECT.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/netfilter/ip6t_REJECT.c
> b/net/ipv6/netfilter/ip6t_REJECT.c
> index 544b0a9..f956513 100644
> --- a/net/ipv6/netfilter/ip6t_REJECT.c
> +++ b/net/ipv6/netfilter/ip6t_REJECT.c
> @@ -42,7 +42,7 @@ reject_tg6(struct sk_buff *skb, const struct
> xt_action_param *par)
>  	const struct ip6t_reject_info *reject = par->targinfo;
>  	struct net *net = dev_net((par->in != NULL) ? par->in : par->out);
> 
> -	pr_debug("%s: medium point\n", __func__);
> +	pr_debug("%s: case %u\n", __func__, reject->with);

I'd suggest you send a patch to remove this debug message to get this
in sync with the IPv4 version of the REJECT target.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-30 11:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-30  2:34 [PATCH nf-next] netfilter: ip6t_REJECT: Log reject reason in reject_tg6() subashab
2015-07-30 11:59 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).