From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Andreas Schultz <aschultz@tpip.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: per network namespace nfacct
Date: Fri, 7 Aug 2015 11:45:31 +0200 [thread overview]
Message-ID: <20150807094531.GA5423@salvia> (raw)
In-Reply-To: <55C364CF.6060609@tpip.net>
On Thu, Aug 06, 2015 at 03:44:47PM +0200, Andreas Schultz wrote:
> On 08/06/2015 03:42 PM, Pablo Neira Ayuso wrote:
[...]
> >With netns in place, we don't know in what order the __net_exit
> >functions are called, ie. We may still have references to objects from
> >xt_nfacct.
>
> Exactly my point, only the xt_nfacct object references also takes a
> module reference. We can not release this reference for them. So
> we remove the nfacct object from the list and only free the object
> if xt_nfacct is *NOT* holding a reference.
>
> If xt_nfacct is holding a reference, it will put that reference together
> with the module reference later.
You're right. This patch is applied, thanks Andreas:
BTW, I have mangled the original subject to:
netfilter: nfacct: per network namespace support
Just for the next time, we prefer this format:
SUBSYS: COMPONENT: description
prev parent reply other threads:[~2015-08-07 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:51 [PATCH] netfilter: per network namespace nfacct Andreas Schultz
2015-08-06 10:07 ` Pablo Neira Ayuso
2015-08-06 10:56 ` Andreas Schultz
2015-08-06 13:42 ` Pablo Neira Ayuso
2015-08-06 13:44 ` Andreas Schultz
2015-08-07 9:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807094531.GA5423@salvia \
--to=pablo@netfilter.org \
--cc=aschultz@tpip.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).