From: Andreas Schultz <aschultz@tpip.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: per network namespace nfacct
Date: Thu, 06 Aug 2015 12:56:06 +0200 [thread overview]
Message-ID: <55C33D46.4080902@tpip.net> (raw)
In-Reply-To: <20150806100713.GA18520@salvia>
On 08/06/2015 12:07 PM, Pablo Neira Ayuso wrote:
> On Wed, Aug 05, 2015 at 05:51:45PM +0200, Andreas Schultz wrote:
[..]
>> +static void __net_exit nfnl_acct_net_exit(struct net *net)
>> +{
>> + struct nf_acct *cur, *tmp;
>> +
>> + list_for_each_entry_safe(cur, tmp, &net->nfnl_acct_list, head) {
>> + list_del_rcu(&cur->head);
>> +
>> + if (atomic_dec_and_test(&cur->refcnt))
>> + kfree_rcu(cur, rcu_head);
>> + }
>> +}
>
> You better use nfnl_acct_put() here, otherwise we leak a module
> refcount.
The module refcount is only taken in nfnl_acct_find_get. The initial
insert into the list in nfnl_acct_new is not taking the module refcount.
Releasing the module refcount here would IMHO release one recount to
many. Or do I miss something?
>
> Other than that, this looks fine with me. Please send a v2.
>
> Thanks.
Andreas
next prev parent reply other threads:[~2015-08-06 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:51 [PATCH] netfilter: per network namespace nfacct Andreas Schultz
2015-08-06 10:07 ` Pablo Neira Ayuso
2015-08-06 10:56 ` Andreas Schultz [this message]
2015-08-06 13:42 ` Pablo Neira Ayuso
2015-08-06 13:44 ` Andreas Schultz
2015-08-07 9:45 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C33D46.4080902@tpip.net \
--to=aschultz@tpip.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).