netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] configure: fix 3rd arg w/AC_ARG_ENABLE
@ 2015-08-15 18:13 Mike Frysinger
  2015-08-18  6:09 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2015-08-15 18:13 UTC (permalink / raw)
  To: netfilter-devel

The 3rd arg is used when --{enable,disable}-foo are passed in, not when
the feature is enabled.  Use the existing $enableval instead.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2521ccc..7ff572a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -53,10 +53,10 @@ AC_ARG_ENABLE([libipq],
 	[enable_libipq="$enableval"], [enable_libipq="no"])
 AC_ARG_ENABLE([bpf-compiler],
 	AS_HELP_STRING([--enable-bpf-compiler], [Build bpf compiler]),
-	[enable_bpfc="yes"], [enable_bpfc="no"])
+	[enable_bpfc="$enableval"], [enable_bpfc="no"])
 AC_ARG_ENABLE([nfsynproxy],
 	AS_HELP_STRING([--enable-nfsynproxy], [Build SYNPROXY configuration tool]),
-	[enable_nfsynproxy="yes"], [enable_nfsynproxy="no"])
+	[enable_nfsynproxy="$enableval"], [enable_nfsynproxy="no"])
 AC_ARG_WITH([pkgconfigdir], AS_HELP_STRING([--with-pkgconfigdir=PATH],
 	[Path to the pkgconfig directory [[LIBDIR/pkgconfig]]]),
 	[pkgconfigdir="$withval"], [pkgconfigdir='${libdir}/pkgconfig'])
-- 
2.4.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] configure: fix 3rd arg w/AC_ARG_ENABLE
  2015-08-15 18:13 [PATCH] configure: fix 3rd arg w/AC_ARG_ENABLE Mike Frysinger
@ 2015-08-18  6:09 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2015-08-18  6:09 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: netfilter-devel

On Sat, Aug 15, 2015 at 02:13:35PM -0400, Mike Frysinger wrote:
> The 3rd arg is used when --{enable,disable}-foo are passed in, not when
> the feature is enabled.  Use the existing $enableval instead.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-18  6:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-15 18:13 [PATCH] configure: fix 3rd arg w/AC_ARG_ENABLE Mike Frysinger
2015-08-18  6:09 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).