[PATCH 1121/1285] Replace numeric parameter like 0444 with macro

* [PATCH 1121/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:18 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:18 UTC (permalink / raw)
  To: pablo, kaber, kadlec, davem, m.szyprowski, kyungmin.park, k.kozlowski
  Cc: netfilter-devel, coreteam, netdev, linux-kernel, chuansheng.liu,
	baolex.ni, aryabinin

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 net/netfilter/nf_conntrack_expect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_conntrack_expect.c b/net/netfilter/nf_conntrack_expect.c
index 9e36931..7a831e4 100644
--- a/net/netfilter/nf_conntrack_expect.c
+++ b/net/netfilter/nf_conntrack_expect.c
@@ -633,7 +633,7 @@ static void exp_proc_remove(struct net *net)
 #endif /* CONFIG_NF_CONNTRACK_PROCFS */
 }
 
-module_param_named(expect_hashsize, nf_ct_expect_hsize, uint, 0400);
+module_param_named(expect_hashsize, nf_ct_expect_hsize, uint, S_IRUSR);
 
 int nf_conntrack_expect_pernet_init(struct net *net)
 {
-- 
2.9.2

^ permalink raw reply related	[flat|nested] only message in thread