* [PATCH nf 1/1] netfilter: CLUSTERIP: Fix one wrong refcnt usage
@ 2017-04-06 1:45 gfree.wind
2017-04-13 21:21 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: gfree.wind @ 2017-04-06 1:45 UTC (permalink / raw)
To: pablo, netfilter-devel; +Cc: Gao Feng
From: Gao Feng <fgao@ikuai8.com>
Current codes invoke wrongly nf_ct_netns_get in the destroy routine,
it should use nf_ct_netns_put, not nf_ct_netns_get.
It could cause some modules could not be unloaded.
Signed-off-by: Gao Feng <fgao@ikuai8.com>
---
net/ipv4/netfilter/ipt_CLUSTERIP.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c b/net/ipv4/netfilter/ipt_CLUSTERIP.c
index 52f2645..9b88413 100644
--- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
+++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
@@ -461,7 +461,7 @@ static void clusterip_tg_destroy(const struct xt_tgdtor_param *par)
clusterip_config_put(cipinfo->config);
- nf_ct_netns_get(par->net, par->family);
+ nf_ct_netns_put(par->net, par->family);
}
#ifdef CONFIG_COMPAT
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf 1/1] netfilter: CLUSTERIP: Fix one wrong refcnt usage
2017-04-06 1:45 [PATCH nf 1/1] netfilter: CLUSTERIP: Fix one wrong refcnt usage gfree.wind
@ 2017-04-13 21:21 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2017-04-13 21:21 UTC (permalink / raw)
To: gfree.wind; +Cc: netfilter-devel, Gao Feng
On Thu, Apr 06, 2017 at 09:45:22AM +0800, gfree.wind@foxmail.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> Current codes invoke wrongly nf_ct_netns_get in the destroy routine,
> it should use nf_ct_netns_put, not nf_ct_netns_get.
> It could cause some modules could not be unloaded.
Applied with patch title:
netfilter: CLUSTERIP: Fix wrong conntrack netns refcnt usage
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 1:45 [PATCH nf 1/1] netfilter: CLUSTERIP: Fix one wrong refcnt usage gfree.wind
2017-04-13 21:21 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).