netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Fernando Fernandez Mancera <ffmancera@riseup.net>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v2 1/6] osf: add version fingerprint support
Date: Thu, 21 Mar 2019 15:06:56 +0100	[thread overview]
Message-ID: <20190321140656.GL4851@orbyte.nwl.cc> (raw)
In-Reply-To: <20190321111818.uqmioy5jk4kbamru@salvia>

On Thu, Mar 21, 2019 at 12:18:18PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Mar 21, 2019 at 12:15:15PM +0100, Phil Sutter wrote:
> > On Thu, Mar 21, 2019 at 09:32:45AM +0100, Pablo Neira Ayuso wrote:
> > > On Wed, Mar 20, 2019 at 02:46:54PM +0100, Phil Sutter wrote:
> > > [...]
> > > > Speaking of sets, it would be awesome if we could support something
> > > > like:
> > > > 
> > > > | osf genre { "Linux:2.4", "Windows" }
> > > 
> > > We can support something like this:
> > > 
> > >         osf version { "Linux:2.4", "Windows\*" }
> > > 
> > > where the wildcard specifies any Windows version.
> > > 
> > > We need a new set type though, to deal with strings.
> > 
> > Given that RHS for osf expression is a string in any option we discussed
> > so far this is inevitable, right?
> > 
> > > > i.e., having elements with varying "granularity". Do you think that's
> > > > feasible? If so, how could we support that? Maybe using a concatenation
> > > > like:
> > > > 
> > > > | osf name . osf version { "Linux" . "2.4", "Windows" . "*" }
> > > 
> > > Not sure we want this level of granularity. Matching the version
> > > without no OS genre does not look useful when I look at how the osf
> > > engine works. I'd prefer we go for the first approach you have
> > > mentioned here above.
> > 
> > I agree. It looks nice on paper, but without further optimization in
> > background it leads to multiple fingerprint lookups for the same
> > package.
> 
> Not if we have a set that implements Aho-Corasick.

I was talking about the "osf name . osf version" part. If not optimized,
each osf expression would perform a database lookup and return different
parts of the fingerprint.

Or did I miss your point?

Cheers, Phil

  reply	other threads:[~2019-03-21 14:07 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 15:14 [PATCH nft v2 1/6] osf: add version fingerprint support Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 2/6] json: osf: add version json support Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 3/6] tests: py: add osf tests with versions Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 4/6] doc: add osf version option to man page Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 5/6] files: osf: update pf.os with newer OS fingerprints Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 6/6] files: pf.os: merge the signatures spllited by version Fernando Fernandez Mancera
2019-03-13  9:44 ` [PATCH nft v2 1/6] osf: add version fingerprint support Phil Sutter
2019-03-13 10:14   ` Fernando Fernandez Mancera
2019-03-13 11:27     ` Phil Sutter
2019-03-13 14:15       ` Fernando Fernandez Mancera
2019-03-13 15:06         ` Phil Sutter
2019-03-13 15:22           ` Fernando Fernandez Mancera
2019-03-13 15:34             ` Phil Sutter
2019-03-13 16:46               ` Fernando Fernandez Mancera
2019-03-14 11:14                 ` Fernando Fernandez Mancera
2019-03-14 13:58                   ` Pablo Neira Ayuso
2019-03-14 17:34                     ` Phil Sutter
2019-03-14 18:24                       ` Fernando Fernandez Mancera
2019-03-15 10:03                         ` Phil Sutter
2019-03-15 17:13                           ` Pablo Neira Ayuso
2019-03-15 20:21                             ` Fernando Fernandez Mancera
2019-03-16  9:05                               ` Pablo Neira Ayuso
2019-03-17 17:10                                 ` Fernando Fernandez Mancera
2019-03-18 17:42                             ` Phil Sutter
2019-03-19 11:06                               ` Pablo Neira Ayuso
2019-03-20 13:46                                 ` Phil Sutter
2019-03-21  8:32                                   ` Pablo Neira Ayuso
2019-03-21 11:15                                     ` Phil Sutter
2019-03-21 11:18                                       ` Pablo Neira Ayuso
2019-03-21 14:06                                         ` Phil Sutter [this message]
2019-03-21 16:57                                           ` Pablo Neira Ayuso
2019-03-21 18:14                                             ` Phil Sutter
2019-03-14 20:07                       ` Pablo Neira Ayuso
2019-03-14 20:13                         ` [PATCH nft v2 1/6] osf: add version fingerprint supportg Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321140656.GL4851@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=ffmancera@riseup.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).