From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Fernando Fernandez Mancera <ffmancera@riseup.net>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v2 1/6] osf: add version fingerprint support
Date: Thu, 21 Mar 2019 19:14:38 +0100 [thread overview]
Message-ID: <20190321181438.GM4851@orbyte.nwl.cc> (raw)
In-Reply-To: <20190321165711.is2jcq3b4yzty6fy@salvia>
On Thu, Mar 21, 2019 at 05:57:11PM +0100, Pablo Neira Ayuso wrote:
> Hi Phil,
>
> On Thu, Mar 21, 2019 at 03:06:56PM +0100, Phil Sutter wrote:
> [...]
> > I was talking about the "osf name . osf version" part. If not optimized,
> > each osf expression would perform a database lookup and return different
> > parts of the fingerprint.
> >
> > Or did I miss your point?
>
> Oops, sorry. I misunderstood.
OK, no worries!
> I don't think we should split this in two separated selectors.
> Matching on 'osf version' alone itself does not make sense to me.
I like how one may use concatenations with it, but I agree it's not
really useful by itself.
> I think it's useful to match on:
>
> * genre
> * genre:version
> * genre:version:subtype
>
> anything else for this, I don't have a use case.
Fine with me!
> We can achieve something similar to what you suggest in your 'osf name
> . osf version' example via:
>
> osf version { "Linux:2.4", "Windows\*" }
Supporting strings in sets would be nice for ifname matches, too. :)
Cheers, Phil
next prev parent reply other threads:[~2019-03-21 18:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:14 [PATCH nft v2 1/6] osf: add version fingerprint support Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 2/6] json: osf: add version json support Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 3/6] tests: py: add osf tests with versions Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 4/6] doc: add osf version option to man page Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 5/6] files: osf: update pf.os with newer OS fingerprints Fernando Fernandez Mancera
2019-03-11 15:14 ` [PATCH nft v2 6/6] files: pf.os: merge the signatures spllited by version Fernando Fernandez Mancera
2019-03-13 9:44 ` [PATCH nft v2 1/6] osf: add version fingerprint support Phil Sutter
2019-03-13 10:14 ` Fernando Fernandez Mancera
2019-03-13 11:27 ` Phil Sutter
2019-03-13 14:15 ` Fernando Fernandez Mancera
2019-03-13 15:06 ` Phil Sutter
2019-03-13 15:22 ` Fernando Fernandez Mancera
2019-03-13 15:34 ` Phil Sutter
2019-03-13 16:46 ` Fernando Fernandez Mancera
2019-03-14 11:14 ` Fernando Fernandez Mancera
2019-03-14 13:58 ` Pablo Neira Ayuso
2019-03-14 17:34 ` Phil Sutter
2019-03-14 18:24 ` Fernando Fernandez Mancera
2019-03-15 10:03 ` Phil Sutter
2019-03-15 17:13 ` Pablo Neira Ayuso
2019-03-15 20:21 ` Fernando Fernandez Mancera
2019-03-16 9:05 ` Pablo Neira Ayuso
2019-03-17 17:10 ` Fernando Fernandez Mancera
2019-03-18 17:42 ` Phil Sutter
2019-03-19 11:06 ` Pablo Neira Ayuso
2019-03-20 13:46 ` Phil Sutter
2019-03-21 8:32 ` Pablo Neira Ayuso
2019-03-21 11:15 ` Phil Sutter
2019-03-21 11:18 ` Pablo Neira Ayuso
2019-03-21 14:06 ` Phil Sutter
2019-03-21 16:57 ` Pablo Neira Ayuso
2019-03-21 18:14 ` Phil Sutter [this message]
2019-03-14 20:07 ` Pablo Neira Ayuso
2019-03-14 20:13 ` [PATCH nft v2 1/6] osf: add version fingerprint supportg Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321181438.GM4851@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=ffmancera@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).