[PATCH nft v1 ] py: nftables.py: fix python3

[PATCH nft v1 ] py: nftables.py: fix python3

[Shekhar Sharma]

This patch converts the 'nftables.py' file (nftables/py/nftables.py) to run on both python2 and python3.


Signed-off-by: Shekhar Sharma <shekhar250198@gmail.com>
---
 py/nftables.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/py/nftables.py b/py/nftables.py
index 33cd2dfd..badcfa5c 100644
--- a/py/nftables.py
+++ b/py/nftables.py
@@ -297,7 +297,7 @@ class Nftables:
         val = self.nft_ctx_output_get_debug(self.__ctx)
 
         names = []
-        for n,v in self.debug_flags.items():
+        for n,v in list(self.debug_flags.items()):
             if val & v:
                 names.append(n)
                 val &= ~v
-- 
2.21.0.windows.1

Re: [PATCH nft v1 ] py: nftables.py: fix python3

[Eric Garver]

On Sat, May 25, 2019 at 12:19:50AM +0530, Shekhar Sharma wrote:
> This patch converts the 'nftables.py' file (nftables/py/nftables.py) to run on both python2 and python3.
> 
> 
> Signed-off-by: Shekhar Sharma <shekhar250198@gmail.com>
> ---
>  py/nftables.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/py/nftables.py b/py/nftables.py
> index 33cd2dfd..badcfa5c 100644
> --- a/py/nftables.py
> +++ b/py/nftables.py
> @@ -297,7 +297,7 @@ class Nftables:
>          val = self.nft_ctx_output_get_debug(self.__ctx)
>  
>          names = []
> -        for n,v in self.debug_flags.items():
> +        for n,v in list(self.debug_flags.items()):
>              if val & v:
>                  names.append(n)
>                  val &= ~v

Are you fixing an issue here? I don't think the conversion to list is
necessary. The dictionary view can still be iterated. The dictionary is
not being modified.

Re: [PATCH nft v1 ] py: nftables.py: fix python3

[shekhar sharma]

On Tue, May 28, 2019 at 7:40 PM Eric Garver <eric@garver.life> wrote:
>
> On Sat, May 25, 2019 at 12:19:50AM +0530, Shekhar Sharma wrote:
> > This patch converts the 'nftables.py' file (nftables/py/nftables.py) to run on both python2 and python3.
> >
> >
> > Signed-off-by: Shekhar Sharma <shekhar250198@gmail.com>
> > ---
> >  py/nftables.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/py/nftables.py b/py/nftables.py
> > index 33cd2dfd..badcfa5c 100644
> > --- a/py/nftables.py
> > +++ b/py/nftables.py
> > @@ -297,7 +297,7 @@ class Nftables:
> >          val = self.nft_ctx_output_get_debug(self.__ctx)
> >
> >          names = []
> > -        for n,v in self.debug_flags.items():
> > +        for n,v in list(self.debug_flags.items()):
> >              if val & v:
> >                  names.append(n)
> >                  val &= ~v
>
> Are you fixing an issue here? I don't think the conversion to list is
> necessary. The dictionary view can still be iterated. The dictionary is
> not being modified.

Yes, when i compiled the code with python3 in my computer, it ran
without the conversion to list
but when i used an online compiler, it complained about it and i read
online that methods like .items and .keys()
do not return iterables in python3 as they do in python2.
I think the conversion is not necessary. We can omit it.

Shekhar