From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Subject: [PATCH nftables 0/4] un-break nftables on big-endian arches
Date: Tue, 13 Aug 2019 20:44:05 +0200 [thread overview]
Message-ID: <20190813184409.10757-1-fw@strlen.de> (raw)
nftables 0.9.1 fails on s390x. Breakage includes:
- "jump foo" is rejected
- chain policies are treated as drop
- chain priority is always set to 0 (same bug though).
Also, last test case reveals problems with receive buffer sizes,
these have been fixed as well.
After these changes, all test cases work, except one.
The failure in that test case is caused by timeout rounding
errors due to CONFIG_HZ=100, I'll leave that for the time being
given HZ=100 is rare noways and the "fix" is to adjust the test case.
Florian Westphal (4):
src: fix jumps on bigendian arches
src: parser: fix parsing of chain priority and policy on bigendian
src: mnl: fix setting rcvbuffer size
src: mnl: retry when we hit -ENOBUFS
datatype.c | 26 +++++++++++++++++---------
mnl.c | 16 +++++++++++-----
netlink.c | 16 +++++++++++++---
parser_bison.y | 7 +++++--
4 files changed, 46 insertions(+), 19 deletions(-)
next reply other threads:[~2019-08-13 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 18:44 Florian Westphal [this message]
2019-08-13 18:44 ` [PATCH nftables 1/4] src: fix jumps on bigendian arches Florian Westphal
2019-08-13 19:20 ` Pablo Neira Ayuso
2019-08-13 19:34 ` Florian Westphal
2019-08-13 19:35 ` Pablo Neira Ayuso
2019-08-13 18:44 ` [PATCH nftables 2/4] src: parser: fix parsing of chain priority and policy on bigendian Florian Westphal
2019-08-13 19:26 ` Pablo Neira Ayuso
2019-08-13 18:44 ` [PATCH nftables 3/4] src: mnl: fix setting rcvbuffer size Florian Westphal
2019-08-13 19:26 ` Pablo Neira Ayuso
2019-08-13 18:44 ` [PATCH nftables 4/4] src: mnl: retry when we hit -ENOBUFS Florian Westphal
2019-08-13 19:34 ` Pablo Neira Ayuso
2019-08-13 19:36 ` Florian Westphal
2019-08-13 19:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813184409.10757-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).