From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2] parser_bison: Fix 'exists' keyword on Big Endian
Date: Sat, 14 Sep 2019 00:35:42 +0200 [thread overview]
Message-ID: <20190913223542.GE10656@breakpoint.cc> (raw)
In-Reply-To: <20190913205622.GC9943@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> On Fri, Sep 13, 2019 at 10:53:44PM +0200, Florian Westphal wrote:
> > Phil Sutter <phil@nwl.cc> wrote:
> > > Size value passed to constant_expr_alloc() must correspond with actual
> > > data size, otherwise wrong portion of data will be taken later when
> > > serializing into netlink message.
> > >
> > > Booleans require really just a bit, but make type of boolean_keys be
> > > uint8_t (introducing new 'val8' name for it) and pass the data length
> > > using sizeof() to avoid any magic numbers.
> > >
> > > While being at it, fix len value in parser_json.c as well although it
> > > worked before due to the value being rounded up to the next multiple of
> > > 8.
> >
> > Looks good, thanks Phil.
>
> So that's an ACK? :)
Yes, feel free to push this.
prev parent reply other threads:[~2019-09-13 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 18:44 [nft PATCH v2] parser_bison: Fix 'exists' keyword on Big Endian Phil Sutter
2019-09-13 20:53 ` Florian Westphal
2019-09-13 20:56 ` Phil Sutter
2019-09-13 22:35 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913223542.GE10656@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).