* [PATCH] Fix a missing doxygen section trailer in nlmsg.c
@ 2019-10-02 6:48 Duncan Roe
2019-10-02 23:56 ` Duncan Roe
0 siblings, 1 reply; 3+ messages in thread
From: Duncan Roe @ 2019-10-02 6:48 UTC (permalink / raw)
To: netfilter-devel
This corrects an oddity in the web doco (and presumably in the man pages as
well) whereby "Netlink message batch helpers" was showing up as a sub-topic of
"Netlink message helpers".
This was included in my original (rejected) patch "Enable doxygen to generate
Function Documentation" with a comment "(didn't think it warrantied an extra
patch)" - clearly wrong
---
src/nlmsg.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/nlmsg.c b/src/nlmsg.c
index fb99135..d398e63 100644
--- a/src/nlmsg.c
+++ b/src/nlmsg.c
@@ -370,6 +370,10 @@ EXPORT_SYMBOL void mnl_nlmsg_fprintf(FILE *fd, const void *data, size_t datalen,
}
}
+/**
+ * @}
+ */
+
/**
* \defgroup batch Netlink message batch helpers
*
--
2.14.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix a missing doxygen section trailer in nlmsg.c
2019-10-02 6:48 [PATCH] Fix a missing doxygen section trailer in nlmsg.c Duncan Roe
@ 2019-10-02 23:56 ` Duncan Roe
2019-10-03 10:24 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Duncan Roe @ 2019-10-02 23:56 UTC (permalink / raw)
To: netfilter-devel
On Wed, Oct 02, 2019 at 04:48:48PM +1000, Duncan Roe wrote:
> This corrects an oddity in the web doco (and presumably in the man pages as
> well) whereby "Netlink message batch helpers" was showing up as a sub-topic of
> "Netlink message helpers".
>
> This was included in my original (rejected) patch "Enable doxygen to generate
> Function Documentation" with a comment "(didn't think it warrantied an extra
> patch)" - clearly wrong
> ---
> src/nlmsg.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/nlmsg.c b/src/nlmsg.c
> index fb99135..d398e63 100644
> --- a/src/nlmsg.c
> +++ b/src/nlmsg.c
> @@ -370,6 +370,10 @@ EXPORT_SYMBOL void mnl_nlmsg_fprintf(FILE *fd, const void *data, size_t datalen,
> }
> }
>
> +/**
> + * @}
> + */
> +
> /**
> * \defgroup batch Netlink message batch helpers
> *
> --
> 2.14.5
>
Sorry, should have mentioned: this patch is for libmnl
Cheers ... Duncan.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix a missing doxygen section trailer in nlmsg.c
2019-10-02 23:56 ` Duncan Roe
@ 2019-10-03 10:24 ` Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2019-10-03 10:24 UTC (permalink / raw)
To: netfilter-devel
On Thu, Oct 03, 2019 at 09:56:34AM +1000, Duncan Roe wrote:
> On Wed, Oct 02, 2019 at 04:48:48PM +1000, Duncan Roe wrote:
> > This corrects an oddity in the web doco (and presumably in the man pages as
> > well) whereby "Netlink message batch helpers" was showing up as a sub-topic of
> > "Netlink message helpers".
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-03 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-02 6:48 [PATCH] Fix a missing doxygen section trailer in nlmsg.c Duncan Roe
2019-10-02 23:56 ` Duncan Roe
2019-10-03 10:24 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).