* [nft PATCH] Revert "main: Fix for misleading error with negative chain priority"
@ 2019-10-23 11:51 Phil Sutter
0 siblings, 0 replies; only message in thread
From: Phil Sutter @ 2019-10-23 11:51 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
This reverts commit 9fc71bc6b602c8706d1214e0100bcd7638c257e3.
Given that this change breaks typical commands like
'nft list ruleset -a' while on the other hand escaping of semicolons and
(depending on shell) curly braces is still required, decision was made
to not go with this solution.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
src/main.c | 2 +-
tests/shell/testcases/chains/0039negative_priority_0 | 8 --------
2 files changed, 1 insertion(+), 9 deletions(-)
delete mode 100755 tests/shell/testcases/chains/0039negative_priority_0
diff --git a/src/main.c b/src/main.c
index 577850e54f68c..f77d8a820a028 100644
--- a/src/main.c
+++ b/src/main.c
@@ -45,7 +45,7 @@ enum opt_vals {
OPT_NUMERIC_TIME = 't',
OPT_INVALID = '?',
};
-#define OPTSTRING "+hvcf:iI:jvnsNaeSupypt"
+#define OPTSTRING "hvcf:iI:jvnsNaeSupypt"
static const struct option options[] = {
{
diff --git a/tests/shell/testcases/chains/0039negative_priority_0 b/tests/shell/testcases/chains/0039negative_priority_0
deleted file mode 100755
index ba17b8cc19eda..0000000000000
--- a/tests/shell/testcases/chains/0039negative_priority_0
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/bin/bash
-
-# Test parsing of negative priority values
-
-set -e
-
-$NFT add table t
-$NFT add chain t c { type filter hook input priority -30\; }
--
2.23.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-23 11:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 11:51 [nft PATCH] Revert "main: Fix for misleading error with negative chain priority" Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).