netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [libnftnl PATCH] utils: Define __visible even if not supported by compiler
@ 2019-11-21 11:24 Phil Sutter
  2019-11-21 13:44 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2019-11-21 11:24 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: netfilter-devel

Since __visible is now used directly, provide a fallback empty
definition if HAVE_VISIBILITY_HIDDEN is not defined.

Fixes: 7349a70634fa0 ("Deprecate untyped data setters")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 include/utils.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/utils.h b/include/utils.h
index 91fbebb1956fd..8af5a8e973fa8 100644
--- a/include/utils.h
+++ b/include/utils.h
@@ -12,6 +12,7 @@
 #	define __visible	__attribute__((visibility("default")))
 #	define EXPORT_SYMBOL(x)	typeof(x) (x) __visible;
 #else
+#	define __visible
 #	define EXPORT_SYMBOL
 #endif
 
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [libnftnl PATCH] utils: Define __visible even if not supported by compiler
  2019-11-21 11:24 [libnftnl PATCH] utils: Define __visible even if not supported by compiler Phil Sutter
@ 2019-11-21 13:44 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2019-11-21 13:44 UTC (permalink / raw)
  To: Phil Sutter; +Cc: netfilter-devel

On Thu, Nov 21, 2019 at 12:24:56PM +0100, Phil Sutter wrote:
> Since __visible is now used directly, provide a fallback empty
> definition if HAVE_VISIBILITY_HIDDEN is not defined.
> 
> Fixes: 7349a70634fa0 ("Deprecate untyped data setters")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-21 13:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 11:24 [libnftnl PATCH] utils: Define __visible even if not supported by compiler Phil Sutter
2019-11-21 13:44 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).