* [PATCH next] nf_tables: make the symbol 'nft_pipapo_get' static
@ 2020-02-10 8:51 Chen Wandun
2020-02-10 15:12 ` Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2020-02-10 8:51 UTC (permalink / raw)
To: pablo, kadlec, fw, davem, kuba, sbrivio, netfilter-devel,
coreteam, netdev, linux-kernel
Cc: chenwandun
Fix the following sparse warning:
net/netfilter/nft_set_pipapo.c:739:6: warning: symbol 'nft_pipapo_get' was not declared. Should it be static?
Fixes: 3c4287f62044 ("nf_tables: Add set type for arbitrary concatenation of ranges")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
net/netfilter/nft_set_pipapo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c
index f0cb1e13af50..f5b9bb6bfcc3 100644
--- a/net/netfilter/nft_set_pipapo.c
+++ b/net/netfilter/nft_set_pipapo.c
@@ -736,8 +736,8 @@ static struct nft_pipapo_elem *pipapo_get(const struct net *net,
* @elem: nftables API element representation containing key data
* @flags: Unused
*/
-void *nft_pipapo_get(const struct net *net, const struct nft_set *set,
- const struct nft_set_elem *elem, unsigned int flags)
+static void *nft_pipapo_get(const struct net *net, const struct nft_set *set,
+ const struct nft_set_elem *elem, unsigned int flags)
{
return pipapo_get(net, set, (const u8 *)elem->key.val.data,
nft_genmask_cur(net));
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] nf_tables: make the symbol 'nft_pipapo_get' static
2020-02-10 8:51 [PATCH next] nf_tables: make the symbol 'nft_pipapo_get' static Chen Wandun
@ 2020-02-10 15:12 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2020-02-10 15:12 UTC (permalink / raw)
To: Chen Wandun
Cc: pablo, kadlec, fw, davem, kuba, netfilter-devel, coreteam,
netdev, linux-kernel
On Mon, 10 Feb 2020 16:51:09 +0800
Chen Wandun <chenwandun@huawei.com> wrote:
> Fix the following sparse warning:
>
> net/netfilter/nft_set_pipapo.c:739:6: warning: symbol 'nft_pipapo_get' was not declared. Should it be static?
Whoops, thanks for fixing this.
> Fixes: 3c4287f62044 ("nf_tables: Add set type for arbitrary concatenation of ranges")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Acked-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 8:51 [PATCH next] nf_tables: make the symbol 'nft_pipapo_get' static Chen Wandun
2020-02-10 15:12 ` Stefano Brivio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).