* [iptables PATCH] nft: Drop pointless assignment
@ 2020-02-17 14:13 Phil Sutter
2020-02-18 13:00 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2020-02-17 14:13 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
No need to set 'i' to zero here, it is not used before the next
assignment.
Fixes: 77e6a93d5c9dc ("xtables: add and set "implict" flag on transaction objects")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
iptables/nft.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/iptables/nft.c b/iptables/nft.c
index 806b77fed462b..2f0a8c4a772f7 100644
--- a/iptables/nft.c
+++ b/iptables/nft.c
@@ -2821,7 +2821,6 @@ retry:
nft_refresh_transaction(h);
- i=0;
list_for_each_entry_safe(err, ne, &h->err_list, head)
mnl_err_list_free(err);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [iptables PATCH] nft: Drop pointless assignment
2020-02-17 14:13 [iptables PATCH] nft: Drop pointless assignment Phil Sutter
@ 2020-02-18 13:00 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2020-02-18 13:00 UTC (permalink / raw)
To: Phil Sutter; +Cc: netfilter-devel
On Mon, Feb 17, 2020 at 03:13:43PM +0100, Phil Sutter wrote:
> No need to set 'i' to zero here, it is not used before the next
> assignment.
Phil, for these nitpicks, you do not need to wait for an Ack.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-18 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 14:13 [iptables PATCH] nft: Drop pointless assignment Phil Sutter
2020-02-18 13:00 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).