From: Florian Westphal <fw@strlen.de>
To: sbezverk <sbezverk@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>
Subject: Re: Proposing to add a structure to UserData
Date: Mon, 17 Feb 2020 15:40:34 +0100 [thread overview]
Message-ID: <20200217144034.GC19559@breakpoint.cc> (raw)
In-Reply-To: <169CDFEB-A792-4063-AEC5-05B1714AED91@gmail.com>
sbezverk <sbezverk@gmail.com> wrote:
> I would like to propose to add some structure to UserData. Currently nft tool uses UserData to carry comments and it prints out whatever is stored in it without much of processing. Since UserData is the only available mechanism to store some metadata for a rule, if it is used, then comments in nft cli get totally screwed up.
Then you are using it wrong :-)
Userdata is structured, its not used only for comments.
Which userdata are you referring to? We have this for
rules, sets, and elements.
> If we could add attributes to UserData indicating type NFT_USERDATA_COMMENT with length, then we could preserve nft comments and at the same time allow to use UserData for other things.
> What do you think?
As far as I can see what you want is already implemented, for example
rule comments live in NFTNL_UDATA_RULE_COMMENT sub-type.
next prev parent reply other threads:[~2020-02-17 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 14:12 Proposing to add a structure to UserData sbezverk
2020-02-17 14:40 ` Florian Westphal [this message]
2020-02-17 15:42 ` sbezverk
2020-02-17 15:48 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217144034.GC19559@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sbezverk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).