Netfilter-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH xtables-addons] doc: fix quoted string in libxt_DNETMAP man-page.
@ 2020-07-21  8:31 Jeremy Sowden
  2020-07-21  9:16 ` Jan Engelhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Sowden @ 2020-07-21  8:31 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Netfilter Devel

In roff, lines beginning with a single quote are control lines.  In the
libxt_DNETMAP man-page there is a single-quoted string at the beginning
of a line, which troff tries and fails to interpret as a macro:

  troff: <standard input>:49: warning: macro 'S'' not defined

This means that the line is not output.

Adjust the formatting of the paragraph to move the string from the
beginning of the line.

Fixes: 2b38d081a50b ("doc: spelling and grammar corrections to DNETMAP")
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 extensions/libxt_DNETMAP.man | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/extensions/libxt_DNETMAP.man b/extensions/libxt_DNETMAP.man
index 7a8fe404435b..56cd2a68c6e6 100644
--- a/extensions/libxt_DNETMAP.man
+++ b/extensions/libxt_DNETMAP.man
@@ -45,8 +45,8 @@ The module creates the following entries for each new specified subnet:
 Contains the binding table for the given \fIsubnet/mask\fP. Each line contains
 \fBprenat address\fR, \fBpostnat address\fR, \fBttl\fR (seconds until the entry
 times out), \fBlasthit\fR (last hit to the entry in seconds relative to system
-boot time). Please note that the \fBttl\fR and \fBlasthit\fR entries contain an
-'\fBS\fR' in case of a static binding.
+boot time). Please note that the \fBttl\fR and \fBlasthit\fR entries contain
+an '\fBS\fR' in case of a static binding.
 .TP
 \fB/proc/net/xt_DNETMAP/\fR\fIsubnet\fR\fB_\fR\fImask\fR\fB_stat\fR
 Contains statistics for a given \fIsubnet/mask\fP. The line contains four
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH xtables-addons] doc: fix quoted string in libxt_DNETMAP man-page.
  2020-07-21  8:31 [PATCH xtables-addons] doc: fix quoted string in libxt_DNETMAP man-page Jeremy Sowden
@ 2020-07-21  9:16 ` Jan Engelhardt
  2020-07-21 12:48   ` Jeremy Sowden
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Engelhardt @ 2020-07-21  9:16 UTC (permalink / raw)
  To: Jeremy Sowden; +Cc: Netfilter Devel

On Tuesday 2020-07-21 10:31, Jeremy Sowden wrote:

>In roff, lines beginning with a single quote are control lines.  In the
>libxt_DNETMAP man-page there is a single-quoted string at the beginning
>of a line, which troff tries and fails to interpret as a macro:

Is there some escaping magic available that would make this work as 
well? I would fear that if the next person (me included) comes around 
to use an editor's "wrap at 80 cols" feature, that the quote might 
re-shift to the start of line. If all else, I'd just pick " over ' - in 
the hope that that does not have a special meaning.

>-boot time). Please note that the \fBttl\fR and \fBlasthit\fR entries contain an
>-'\fBS\fR' in case of a static binding.
>+boot time). Please note that the \fBttl\fR and \fBlasthit\fR entries contain
>+an '\fBS\fR' in case of a static binding.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH xtables-addons] doc: fix quoted string in libxt_DNETMAP man-page.
  2020-07-21  9:16 ` Jan Engelhardt
@ 2020-07-21 12:48   ` Jeremy Sowden
  0 siblings, 0 replies; 3+ messages in thread
From: Jeremy Sowden @ 2020-07-21 12:48 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Netfilter Devel


[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

On 2020-07-21, at 11:16:00 +0200, Jan Engelhardt wrote:
> On Tuesday 2020-07-21 10:31, Jeremy Sowden wrote:
> > In roff, lines beginning with a single quote are control lines.  In
> > the libxt_DNETMAP man-page there is a single-quoted string at the
> > beginning of a line, which troff tries and fails to interpret as a
> > macro:
>
> Is there some escaping magic available that would make this work as
> well? I would fear that if the next person (me included) comes around
> to use an editor's "wrap at 80 cols" feature, that the quote might
> re-shift to the start of line. If all else, I'd just pick " over ' -
> in the hope that that does not have a special meaning.

Good point.  I had another look at the documentation and found escape-
sequences for opening and closing single quotes.  I'll send out a new
version of the patch.

> > -boot time). Please note that the \fBttl\fR and \fBlasthit\fR entries contain an
> > -'\fBS\fR' in case of a static binding.
> > +boot time). Please note that the \fBttl\fR and \fBlasthit\fR entries contain
> > +an '\fBS\fR' in case of a static binding.

J.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21  8:31 [PATCH xtables-addons] doc: fix quoted string in libxt_DNETMAP man-page Jeremy Sowden
2020-07-21  9:16 ` Jan Engelhardt
2020-07-21 12:48   ` Jeremy Sowden

Netfilter-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netfilter-devel/0 netfilter-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netfilter-devel netfilter-devel/ https://lore.kernel.org/netfilter-devel \
		netfilter-devel@vger.kernel.org
	public-inbox-index netfilter-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netfilter-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git