* [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled
@ 2020-07-17 16:24 Andrew Sy Kim
2020-07-17 17:36 ` Julian Anastasov
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Sy Kim @ 2020-07-17 16:24 UTC (permalink / raw)
Cc: Julian Anastasov, Wensong Zhang, Simon Horman, lvs-devel,
netfilter-devel, Andrew Sy Kim
Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when
CONFIG_SYSCTL is disabled
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
---
include/net/ip_vs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 91a9e1d590a6..9a59a33787cb 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -1533,7 +1533,7 @@ static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs)
void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs);
#else
-static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs) {}
+static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs) {}
#endif
#define IP_VS_DFWD_METHOD(dest) (atomic_read(&(dest)->conn_flags) & \
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled
2020-07-17 16:24 [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled Andrew Sy Kim
@ 2020-07-17 17:36 ` Julian Anastasov
2020-07-21 23:20 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Julian Anastasov @ 2020-07-17 17:36 UTC (permalink / raw)
To: Andrew Sy Kim
Cc: Wensong Zhang, Simon Horman, Pablo Neira Ayuso, lvs-devel,
netfilter-devel, Randy Dunlap, netdev
Hello,
On Fri, 17 Jul 2020, Andrew Sy Kim wrote:
> Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when
> CONFIG_SYSCTL is disabled
>
> Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Pablo, please apply this too.
> ---
> include/net/ip_vs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
> index 91a9e1d590a6..9a59a33787cb 100644
> --- a/include/net/ip_vs.h
> +++ b/include/net/ip_vs.h
> @@ -1533,7 +1533,7 @@ static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs)
>
> void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs);
> #else
> -static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs) {}
> +static inline void ip_vs_enqueue_expire_nodest_conns(struct netns_ipvs *ipvs) {}
> #endif
>
> #define IP_VS_DFWD_METHOD(dest) (atomic_read(&(dest)->conn_flags) & \
> --
> 2.20.1
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled
2020-07-17 17:36 ` Julian Anastasov
@ 2020-07-21 23:20 ` Pablo Neira Ayuso
2020-07-22 6:03 ` Julian Anastasov
0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2020-07-21 23:20 UTC (permalink / raw)
To: Julian Anastasov
Cc: Andrew Sy Kim, Wensong Zhang, Simon Horman, lvs-devel,
netfilter-devel, Randy Dunlap, netdev
On Fri, Jul 17, 2020 at 08:36:36PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Fri, 17 Jul 2020, Andrew Sy Kim wrote:
>
> > Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when
> > CONFIG_SYSCTL is disabled
> >
> > Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
>
> Pablo, please apply this too.
I have squashed this fix and "ipvs: ensure RCU read unlock when
connection flushing and ipvs is disabled" into the original patch:
"ipvs: queue delayed work to expire no destination connections if
expire_nodest_conn=1"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled
2020-07-21 23:20 ` Pablo Neira Ayuso
@ 2020-07-22 6:03 ` Julian Anastasov
0 siblings, 0 replies; 4+ messages in thread
From: Julian Anastasov @ 2020-07-22 6:03 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: Andrew Sy Kim, Wensong Zhang, Simon Horman, lvs-devel,
netfilter-devel, Randy Dunlap, netdev
Hello,
On Wed, 22 Jul 2020, Pablo Neira Ayuso wrote:
> On Fri, Jul 17, 2020 at 08:36:36PM +0300, Julian Anastasov wrote:
> >
> > On Fri, 17 Jul 2020, Andrew Sy Kim wrote:
> >
> > > Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when
> > > CONFIG_SYSCTL is disabled
> > >
> > > Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
> >
> > Pablo, please apply this too.
>
> I have squashed this fix and "ipvs: ensure RCU read unlock when
> connection flushing and ipvs is disabled" into the original patch:
>
> "ipvs: queue delayed work to expire no destination connections if
> expire_nodest_conn=1"
Very good, thanks!
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-22 6:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 16:24 [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled Andrew Sy Kim
2020-07-17 17:36 ` Julian Anastasov
2020-07-21 23:20 ` Pablo Neira Ayuso
2020-07-22 6:03 ` Julian Anastasov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).