* [PATCH 0/5] Netfilter fixes for net
@ 2020-09-08 15:09 Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 1/5] netfilter: ctnetlink: add a range check for l3/l4 protonum Pablo Neira Ayuso
` (5 more replies)
0 siblings, 6 replies; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 15:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
Hi,
The following patchset contains Netfilter fixes for net:
1) Allow conntrack entries with l3num == NFPROTO_IPV4 or == NFPROTO_IPV6
only via ctnetlink, from Will McVicker.
2) Batch notifications to userspace to improve netlink socket receive
utilization.
3) Restore mark based dump filtering via ctnetlink, from Martin Willi.
4) nf_conncount_init() fails with -EPROTO with CONFIG_IPV6, from
Eelco Chaudron.
5) Containers fail to match on meta skuid and skgid, use socket user_ns
to retrieve meta skuid and skgid.
Please, pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thank you.
----------------------------------------------------------------
The following changes since commit 19162fd4063a3211843b997a454b505edb81d5ce:
hv_netvsc: Fix hibernation for mlx5 VF driver (2020-09-07 21:04:36 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 0c92411bb81de9bc516d6924f50289d8d5f880e5:
netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid (2020-09-08 13:04:56 +0200)
----------------------------------------------------------------
Eelco Chaudron (1):
netfilter: conntrack: nf_conncount_init is failing with IPv6 disabled
Martin Willi (1):
netfilter: ctnetlink: fix mark based dump filtering regression
Pablo Neira Ayuso (2):
netfilter: nf_tables: coalesce multiple notifications into one skbuff
netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid
Will McVicker (1):
netfilter: ctnetlink: add a range check for l3/l4 protonum
include/net/netns/nftables.h | 1 +
net/netfilter/nf_conntrack_netlink.c | 22 +++---------
net/netfilter/nf_conntrack_proto.c | 2 ++
net/netfilter/nf_tables_api.c | 70 +++++++++++++++++++++++++++++-------
net/netfilter/nft_meta.c | 4 +--
5 files changed, 67 insertions(+), 32 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/5] netfilter: ctnetlink: add a range check for l3/l4 protonum
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
@ 2020-09-08 15:09 ` Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 2/5] netfilter: nf_tables: coalesce multiple notifications into one skbuff Pablo Neira Ayuso
` (4 subsequent siblings)
5 siblings, 0 replies; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 15:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
From: Will McVicker <willmcvicker@google.com>
The indexes to the nf_nat_l[34]protos arrays come from userspace. So
check the tuple's family, e.g. l3num, when creating the conntrack in
order to prevent an OOB memory access during setup. Here is an example
kernel panic on 4.14.180 when userspace passes in an index greater than
NFPROTO_NUMPROTO.
Internal error: Oops - BUG: 0 [#1] PREEMPT SMP
Modules linked in:...
Process poc (pid: 5614, stack limit = 0x00000000a3933121)
CPU: 4 PID: 5614 Comm: poc Tainted: G S W O 4.14.180-g051355490483
Hardware name: Qualcomm Technologies, Inc. SM8150 V2 PM8150 Google Inc. MSM
task: 000000002a3dfffe task.stack: 00000000a3933121
pc : __cfi_check_fail+0x1c/0x24
lr : __cfi_check_fail+0x1c/0x24
...
Call trace:
__cfi_check_fail+0x1c/0x24
name_to_dev_t+0x0/0x468
nfnetlink_parse_nat_setup+0x234/0x258
ctnetlink_parse_nat_setup+0x4c/0x228
ctnetlink_new_conntrack+0x590/0xc40
nfnetlink_rcv_msg+0x31c/0x4d4
netlink_rcv_skb+0x100/0x184
nfnetlink_rcv+0xf4/0x180
netlink_unicast+0x360/0x770
netlink_sendmsg+0x5a0/0x6a4
___sys_sendmsg+0x314/0x46c
SyS_sendmsg+0xb4/0x108
el0_svc_naked+0x34/0x38
This crash is not happening since 5.4+, however, ctnetlink still
allows for creating entries with unsupported layer 3 protocol number.
Fixes: c1d10adb4a521 ("[NETFILTER]: Add ctnetlink port for nf_conntrack")
Signed-off-by: Will McVicker <willmcvicker@google.com>
[pablo@netfilter.org: rebased original patch on top of nf.git]
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nf_conntrack_netlink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 832eabecfbdd..d65846aa8059 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1404,7 +1404,8 @@ ctnetlink_parse_tuple_filter(const struct nlattr * const cda[],
if (err < 0)
return err;
-
+ if (l3num != NFPROTO_IPV4 && l3num != NFPROTO_IPV6)
+ return -EOPNOTSUPP;
tuple->src.l3num = l3num;
if (flags & CTA_FILTER_FLAG(CTA_IP_DST) ||
--
2.20.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/5] netfilter: nf_tables: coalesce multiple notifications into one skbuff
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 1/5] netfilter: ctnetlink: add a range check for l3/l4 protonum Pablo Neira Ayuso
@ 2020-09-08 15:09 ` Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 3/5] netfilter: ctnetlink: fix mark based dump filtering regression Pablo Neira Ayuso
` (3 subsequent siblings)
5 siblings, 0 replies; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 15:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
On x86_64, each notification results in one skbuff allocation which
consumes at least 768 bytes due to the skbuff overhead.
This patch coalesces several notifications into one single skbuff, so
each notification consumes at least ~211 bytes, that ~3.5 times less
memory consumption. As a result, this is reducing the chances to exhaust
the netlink socket receive buffer.
Rule of thumb is that each notification batch only contains netlink
messages whose report flag is the same, nfnetlink_send() requires this
to do appropriate delivery to userspace, either via unicast (echo
mode) or multicast (monitor mode).
The skbuff control buffer is used to annotate the report flag for later
handling at the new coalescing routine.
The batch skbuff notification size is NLMSG_GOODSIZE, using a larger
skbuff would allow for more socket receiver buffer savings (to amortize
the cost of the skbuff even more), however, going over that size might
break userspace applications, so let's be conservative and stick to
NLMSG_GOODSIZE.
Reported-by: Phil Sutter <phil@nwl.cc>
Acked-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
include/net/netns/nftables.h | 1 +
net/netfilter/nf_tables_api.c | 70 ++++++++++++++++++++++++++++-------
2 files changed, 58 insertions(+), 13 deletions(-)
diff --git a/include/net/netns/nftables.h b/include/net/netns/nftables.h
index a1a8d45adb42..6c0806bd8d1e 100644
--- a/include/net/netns/nftables.h
+++ b/include/net/netns/nftables.h
@@ -8,6 +8,7 @@ struct netns_nftables {
struct list_head tables;
struct list_head commit_list;
struct list_head module_list;
+ struct list_head notify_list;
struct mutex commit_mutex;
unsigned int base_seq;
u8 gencursor;
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index b7dc1cbf40ea..4603b667973a 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -684,6 +684,18 @@ static int nf_tables_fill_table_info(struct sk_buff *skb, struct net *net,
return -1;
}
+struct nftnl_skb_parms {
+ bool report;
+};
+#define NFT_CB(skb) (*(struct nftnl_skb_parms*)&((skb)->cb))
+
+static void nft_notify_enqueue(struct sk_buff *skb, bool report,
+ struct list_head *notify_list)
+{
+ NFT_CB(skb).report = report;
+ list_add_tail(&skb->list, notify_list);
+}
+
static void nf_tables_table_notify(const struct nft_ctx *ctx, int event)
{
struct sk_buff *skb;
@@ -715,8 +727,7 @@ static void nf_tables_table_notify(const struct nft_ctx *ctx, int event)
goto err;
}
- nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES,
- ctx->report, GFP_KERNEL);
+ nft_notify_enqueue(skb, ctx->report, &ctx->net->nft.notify_list);
return;
err:
nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -1468,8 +1479,7 @@ static void nf_tables_chain_notify(const struct nft_ctx *ctx, int event)
goto err;
}
- nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES,
- ctx->report, GFP_KERNEL);
+ nft_notify_enqueue(skb, ctx->report, &ctx->net->nft.notify_list);
return;
err:
nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -2807,8 +2817,7 @@ static void nf_tables_rule_notify(const struct nft_ctx *ctx,
goto err;
}
- nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES,
- ctx->report, GFP_KERNEL);
+ nft_notify_enqueue(skb, ctx->report, &ctx->net->nft.notify_list);
return;
err:
nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -3837,8 +3846,7 @@ static void nf_tables_set_notify(const struct nft_ctx *ctx,
goto err;
}
- nfnetlink_send(skb, ctx->net, portid, NFNLGRP_NFTABLES, ctx->report,
- gfp_flags);
+ nft_notify_enqueue(skb, ctx->report, &ctx->net->nft.notify_list);
return;
err:
nfnetlink_set_err(ctx->net, portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -4959,8 +4967,7 @@ static void nf_tables_setelem_notify(const struct nft_ctx *ctx,
goto err;
}
- nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, ctx->report,
- GFP_KERNEL);
+ nft_notify_enqueue(skb, ctx->report, &ctx->net->nft.notify_list);
return;
err:
nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -6275,7 +6282,7 @@ void nft_obj_notify(struct net *net, const struct nft_table *table,
goto err;
}
- nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, report, gfp);
+ nft_notify_enqueue(skb, report, &net->nft.notify_list);
return;
err:
nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -7085,8 +7092,7 @@ static void nf_tables_flowtable_notify(struct nft_ctx *ctx,
goto err;
}
- nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES,
- ctx->report, GFP_KERNEL);
+ nft_notify_enqueue(skb, ctx->report, &ctx->net->nft.notify_list);
return;
err:
nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS);
@@ -7695,6 +7701,41 @@ static void nf_tables_commit_release(struct net *net)
mutex_unlock(&net->nft.commit_mutex);
}
+static void nft_commit_notify(struct net *net, u32 portid)
+{
+ struct sk_buff *batch_skb = NULL, *nskb, *skb;
+ unsigned char *data;
+ int len;
+
+ list_for_each_entry_safe(skb, nskb, &net->nft.notify_list, list) {
+ if (!batch_skb) {
+new_batch:
+ batch_skb = skb;
+ len = NLMSG_GOODSIZE - skb->len;
+ list_del(&skb->list);
+ continue;
+ }
+ len -= skb->len;
+ if (len > 0 && NFT_CB(skb).report == NFT_CB(batch_skb).report) {
+ data = skb_put(batch_skb, skb->len);
+ memcpy(data, skb->data, skb->len);
+ list_del(&skb->list);
+ kfree_skb(skb);
+ continue;
+ }
+ nfnetlink_send(batch_skb, net, portid, NFNLGRP_NFTABLES,
+ NFT_CB(batch_skb).report, GFP_KERNEL);
+ goto new_batch;
+ }
+
+ if (batch_skb) {
+ nfnetlink_send(batch_skb, net, portid, NFNLGRP_NFTABLES,
+ NFT_CB(batch_skb).report, GFP_KERNEL);
+ }
+
+ WARN_ON_ONCE(!list_empty(&net->nft.notify_list));
+}
+
static int nf_tables_commit(struct net *net, struct sk_buff *skb)
{
struct nft_trans *trans, *next;
@@ -7897,6 +7938,7 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)
}
}
+ nft_commit_notify(net, NETLINK_CB(skb).portid);
nf_tables_gen_notify(net, skb, NFT_MSG_NEWGEN);
nf_tables_commit_release(net);
@@ -8721,6 +8763,7 @@ static int __net_init nf_tables_init_net(struct net *net)
INIT_LIST_HEAD(&net->nft.tables);
INIT_LIST_HEAD(&net->nft.commit_list);
INIT_LIST_HEAD(&net->nft.module_list);
+ INIT_LIST_HEAD(&net->nft.notify_list);
mutex_init(&net->nft.commit_mutex);
net->nft.base_seq = 1;
net->nft.validate_state = NFT_VALIDATE_SKIP;
@@ -8737,6 +8780,7 @@ static void __net_exit nf_tables_exit_net(struct net *net)
mutex_unlock(&net->nft.commit_mutex);
WARN_ON_ONCE(!list_empty(&net->nft.tables));
WARN_ON_ONCE(!list_empty(&net->nft.module_list));
+ WARN_ON_ONCE(!list_empty(&net->nft.notify_list));
}
static struct pernet_operations nf_tables_net_ops = {
--
2.20.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 3/5] netfilter: ctnetlink: fix mark based dump filtering regression
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 1/5] netfilter: ctnetlink: add a range check for l3/l4 protonum Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 2/5] netfilter: nf_tables: coalesce multiple notifications into one skbuff Pablo Neira Ayuso
@ 2020-09-08 15:09 ` Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 4/5] netfilter: conntrack: nf_conncount_init is failing with IPv6 disabled Pablo Neira Ayuso
` (2 subsequent siblings)
5 siblings, 0 replies; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 15:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
From: Martin Willi <martin@strongswan.org>
conntrack mark based dump filtering may falsely skip entries if a mask
is given: If the mask-based check does not filter out the entry, the
else-if check is always true and compares the mark without considering
the mask. The if/else-if logic seems wrong.
Given that the mask during filter setup is implicitly set to 0xffffffff
if not specified explicitly, the mark filtering flags seem to just
complicate things. Restore the previously used approach by always
matching against a zero mask is no filter mark is given.
Fixes: cb8aa9a3affb ("netfilter: ctnetlink: add kernel side filtering for dump")
Signed-off-by: Martin Willi <martin@strongswan.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nf_conntrack_netlink.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index d65846aa8059..c3a4214dc958 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -851,7 +851,6 @@ static int ctnetlink_done(struct netlink_callback *cb)
}
struct ctnetlink_filter {
- u_int32_t cta_flags;
u8 family;
u_int32_t orig_flags;
@@ -906,10 +905,6 @@ static int ctnetlink_parse_tuple_filter(const struct nlattr * const cda[],
struct nf_conntrack_zone *zone,
u_int32_t flags);
-/* applied on filters */
-#define CTA_FILTER_F_CTA_MARK (1 << 0)
-#define CTA_FILTER_F_CTA_MARK_MASK (1 << 1)
-
static struct ctnetlink_filter *
ctnetlink_alloc_filter(const struct nlattr * const cda[], u8 family)
{
@@ -930,14 +925,10 @@ ctnetlink_alloc_filter(const struct nlattr * const cda[], u8 family)
#ifdef CONFIG_NF_CONNTRACK_MARK
if (cda[CTA_MARK]) {
filter->mark.val = ntohl(nla_get_be32(cda[CTA_MARK]));
- filter->cta_flags |= CTA_FILTER_FLAG(CTA_MARK);
-
- if (cda[CTA_MARK_MASK]) {
+ if (cda[CTA_MARK_MASK])
filter->mark.mask = ntohl(nla_get_be32(cda[CTA_MARK_MASK]));
- filter->cta_flags |= CTA_FILTER_FLAG(CTA_MARK_MASK);
- } else {
+ else
filter->mark.mask = 0xffffffff;
- }
} else if (cda[CTA_MARK_MASK]) {
err = -EINVAL;
goto err_filter;
@@ -1117,11 +1108,7 @@ static int ctnetlink_filter_match(struct nf_conn *ct, void *data)
}
#ifdef CONFIG_NF_CONNTRACK_MARK
- if ((filter->cta_flags & CTA_FILTER_FLAG(CTA_MARK_MASK)) &&
- (ct->mark & filter->mark.mask) != filter->mark.val)
- goto ignore_entry;
- else if ((filter->cta_flags & CTA_FILTER_FLAG(CTA_MARK)) &&
- ct->mark != filter->mark.val)
+ if ((ct->mark & filter->mark.mask) != filter->mark.val)
goto ignore_entry;
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 4/5] netfilter: conntrack: nf_conncount_init is failing with IPv6 disabled
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
` (2 preceding siblings ...)
2020-09-08 15:09 ` [PATCH 3/5] netfilter: ctnetlink: fix mark based dump filtering regression Pablo Neira Ayuso
@ 2020-09-08 15:09 ` Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 5/5] netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid Pablo Neira Ayuso
2020-09-09 3:08 ` [PATCH 0/5] Netfilter fixes for net David Miller
5 siblings, 0 replies; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 15:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
From: Eelco Chaudron <echaudro@redhat.com>
The openvswitch module fails initialization when used in a kernel
without IPv6 enabled. nf_conncount_init() fails because the ct code
unconditionally tries to initialize the netns IPv6 related bit,
regardless of the build option. The change below ignores the IPv6
part if not enabled.
Note that the corresponding _put() function already has this IPv6
configuration check.
Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit")
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nf_conntrack_proto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/netfilter/nf_conntrack_proto.c b/net/netfilter/nf_conntrack_proto.c
index 95f79980348c..47e9319d2cf3 100644
--- a/net/netfilter/nf_conntrack_proto.c
+++ b/net/netfilter/nf_conntrack_proto.c
@@ -565,6 +565,7 @@ static int nf_ct_netns_inet_get(struct net *net)
int err;
err = nf_ct_netns_do_get(net, NFPROTO_IPV4);
+#if IS_ENABLED(CONFIG_IPV6)
if (err < 0)
goto err1;
err = nf_ct_netns_do_get(net, NFPROTO_IPV6);
@@ -575,6 +576,7 @@ static int nf_ct_netns_inet_get(struct net *net)
err2:
nf_ct_netns_put(net, NFPROTO_IPV4);
err1:
+#endif
return err;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 5/5] netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
` (3 preceding siblings ...)
2020-09-08 15:09 ` [PATCH 4/5] netfilter: conntrack: nf_conncount_init is failing with IPv6 disabled Pablo Neira Ayuso
@ 2020-09-08 15:09 ` Pablo Neira Ayuso
2020-09-09 3:08 ` [PATCH 0/5] Netfilter fixes for net David Miller
5 siblings, 0 replies; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-08 15:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
... instead of using init_user_ns.
Fixes: 96518518cc41 ("netfilter: add nftables")
Tested-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nft_meta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 7bc6537f3ccb..b37bd02448d8 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -147,11 +147,11 @@ nft_meta_get_eval_skugid(enum nft_meta_keys key,
switch (key) {
case NFT_META_SKUID:
- *dest = from_kuid_munged(&init_user_ns,
+ *dest = from_kuid_munged(sock_net(sk)->user_ns,
sock->file->f_cred->fsuid);
break;
case NFT_META_SKGID:
- *dest = from_kgid_munged(&init_user_ns,
+ *dest = from_kgid_munged(sock_net(sk)->user_ns,
sock->file->f_cred->fsgid);
break;
default:
--
2.20.1
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
` (4 preceding siblings ...)
2020-09-08 15:09 ` [PATCH 5/5] netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid Pablo Neira Ayuso
@ 2020-09-09 3:08 ` David Miller
5 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2020-09-09 3:08 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev, kuba
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 8 Sep 2020 17:09:42 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Allow conntrack entries with l3num == NFPROTO_IPV4 or == NFPROTO_IPV6
> only via ctnetlink, from Will McVicker.
>
> 2) Batch notifications to userspace to improve netlink socket receive
> utilization.
>
> 3) Restore mark based dump filtering via ctnetlink, from Martin Willi.
>
> 4) nf_conncount_init() fails with -EPROTO with CONFIG_IPV6, from
> Eelco Chaudron.
>
> 5) Containers fail to match on meta skuid and skgid, use socket user_ns
> to retrieve meta skuid and skgid.
>
> Please, pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks Pablo.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2020-08-04 20:02 Pablo Neira Ayuso
@ 2020-08-04 20:32 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2020-08-04 20:32 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 4 Aug 2020 22:02:03 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Flush the cleanup xtables worker to make sure destructors
> have completed, from Florian Westphal.
>
> 2) iifgroup is matching erroneously, also from Florian.
>
> 3) Add selftest for meta interface matching, from Florian Westphal.
>
> 4) Move nf_ct_offload_timeout() to header, from Roi Dayan.
>
> 5) Call nf_ct_offload_timeout() from flow_offload_add() to
> make sure garbage collection does not evict offloaded flow,
> from Roi Dayan.
>
> Please, pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks Pablo.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2020-08-04 20:02 Pablo Neira Ayuso
2020-08-04 20:32 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-08-04 20:02 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi,
The following patchset contains Netfilter fixes for net:
1) Flush the cleanup xtables worker to make sure destructors
have completed, from Florian Westphal.
2) iifgroup is matching erroneously, also from Florian.
3) Add selftest for meta interface matching, from Florian Westphal.
4) Move nf_ct_offload_timeout() to header, from Roi Dayan.
5) Call nf_ct_offload_timeout() from flow_offload_add() to
make sure garbage collection does not evict offloaded flow,
from Roi Dayan.
Please, pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thank you!
----------------------------------------------------------------
The following changes since commit 85496a29224188051b6135eb38da8afd4c584765:
net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe() (2020-07-30 17:45:13 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 4203b19c27967d9eff6928f6a733f81892ffc592:
netfilter: flowtable: Set offload timeout when adding flow (2020-08-03 12:37:24 +0200)
----------------------------------------------------------------
Florian Westphal (3):
netfilter: nft_compat: make sure xtables destructors have run
netfilter: nft_meta: fix iifgroup matching
selftests: netfilter: add meta iif/oif match test
Roi Dayan (2):
netfilter: conntrack: Move nf_ct_offload_timeout to header file
netfilter: flowtable: Set offload timeout when adding flow
include/net/netfilter/nf_conntrack.h | 12 +++
include/net/netfilter/nf_tables.h | 2 +
net/netfilter/nf_conntrack_core.c | 12 ---
net/netfilter/nf_flow_table_core.c | 2 +
net/netfilter/nf_tables_api.c | 10 ++-
net/netfilter/nft_compat.c | 36 +++++++-
net/netfilter/nft_meta.c | 2 +-
tools/testing/selftests/netfilter/Makefile | 2 +-
tools/testing/selftests/netfilter/nft_meta.sh | 124 ++++++++++++++++++++++++++
9 files changed, 182 insertions(+), 20 deletions(-)
create mode 100755 tools/testing/selftests/netfilter/nft_meta.sh
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2020-05-26 20:10 ` Pablo Neira Ayuso
@ 2020-05-26 23:08 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2020-05-26 23:08 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev, kuba
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 26 May 2020 22:10:23 +0200
> If it's still possible, it would be good to toss this pull request.
>
> Otherwise, I will send another pull request to address the kbuild
> reports.
Unfortunately I pushed it out already, please send me follow-ups.
Thanks.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2020-05-26 1:29 ` David Miller
@ 2020-05-26 20:10 ` Pablo Neira Ayuso
2020-05-26 23:08 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-05-26 20:10 UTC (permalink / raw)
To: David Miller; +Cc: netfilter-devel, netdev, kuba
On Mon, May 25, 2020 at 06:29:01PM -0700, David Miller wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> Date: Mon, 25 May 2020 23:54:15 +0200
>
> > The following patchset contains Netfilter fixes for net:
> >
> > 1) Set VLAN tag in tcp reset/icmp unreachable packets to reject
> > connections in the bridge family, from Michael Braun.
> >
> > 2) Incorrect subcounter flag update in ipset, from Phil Sutter.
> >
> > 3) Possible buffer overflow in the pptp conntrack helper, based
> > on patch from Dan Carpenter.
> >
> > 4) Restore userspace conntrack helper hook logic that broke after
> > hook consolidation rework.
> >
> > 5) Unbreak userspace conntrack helper registration via
> > nfnetlink_cthelper.
> >
> > You can pull these changes from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
>
> Pulled, thank you.
If it's still possible, it would be good to toss this pull request.
Otherwise, I will send another pull request to address the kbuild
reports.
Thank you.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2020-05-25 21:54 Pablo Neira Ayuso
@ 2020-05-26 1:29 ` David Miller
2020-05-26 20:10 ` Pablo Neira Ayuso
0 siblings, 1 reply; 33+ messages in thread
From: David Miller @ 2020-05-26 1:29 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev, kuba
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 25 May 2020 23:54:15 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Set VLAN tag in tcp reset/icmp unreachable packets to reject
> connections in the bridge family, from Michael Braun.
>
> 2) Incorrect subcounter flag update in ipset, from Phil Sutter.
>
> 3) Possible buffer overflow in the pptp conntrack helper, based
> on patch from Dan Carpenter.
>
> 4) Restore userspace conntrack helper hook logic that broke after
> hook consolidation rework.
>
> 5) Unbreak userspace conntrack helper registration via
> nfnetlink_cthelper.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thank you.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2020-05-25 21:54 Pablo Neira Ayuso
2020-05-26 1:29 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2020-05-25 21:54 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev, kuba
Hi,
The following patchset contains Netfilter fixes for net:
1) Set VLAN tag in tcp reset/icmp unreachable packets to reject
connections in the bridge family, from Michael Braun.
2) Incorrect subcounter flag update in ipset, from Phil Sutter.
3) Possible buffer overflow in the pptp conntrack helper, based
on patch from Dan Carpenter.
4) Restore userspace conntrack helper hook logic that broke after
hook consolidation rework.
5) Unbreak userspace conntrack helper registration via
nfnetlink_cthelper.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thank you.
----------------------------------------------------------------
The following changes since commit 98790bbac4db1697212ce9462ec35ca09c4a2810:
Merge tag 'efi-urgent-2020-05-24' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2020-05-24 10:24:10 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 703acd70f2496537457186211c2f03e792409e68:
netfilter: nfnetlink_cthelper: unbreak userspace helper support (2020-05-25 20:39:14 +0200)
----------------------------------------------------------------
Michael Braun (1):
netfilter: nft_reject_bridge: enable reject with bridge vlan
Pablo Neira Ayuso (3):
netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code
netfilter: conntrack: make conntrack userspace helpers work again
netfilter: nfnetlink_cthelper: unbreak userspace helper support
Phil Sutter (1):
netfilter: ipset: Fix subcounter update skip
include/linux/netfilter/nf_conntrack_pptp.h | 2 +-
net/bridge/netfilter/nft_reject_bridge.c | 6 +++
net/ipv4/netfilter/nf_nat_pptp.c | 7 +--
net/netfilter/ipset/ip_set_list_set.c | 2 +-
net/netfilter/nf_conntrack_core.c | 78 ++++++++++++++++++++++++++---
net/netfilter/nf_conntrack_pptp.c | 62 +++++++++++++----------
net/netfilter/nfnetlink_cthelper.c | 3 +-
7 files changed, 119 insertions(+), 41 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2019-09-25 20:29 Pablo Neira Ayuso
@ 2019-09-27 18:16 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2019-09-27 18:16 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Wed, 25 Sep 2019 22:29:58 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Add NFT_CHAIN_POLICY_UNSET to replace hardcoded -1 to
> specify that the chain policy is unset. The chain policy
> field is actually defined as an 8-bit unsigned integer.
>
> 2) Remove always true condition reported by smatch in
> chain policy check.
>
> 3) Fix element lookup on dynamic sets, from Florian Westphal.
>
> 4) Use __u8 in ebtables uapi header, from Masahiro Yamada.
>
> 5) Bogus EBUSY when removing flowtable after chain flush,
> from Laura Garcia Liebana.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks Pablo.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2019-09-25 20:29 Pablo Neira Ayuso
2019-09-27 18:16 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2019-09-25 20:29 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi,
The following patchset contains Netfilter fixes for net:
1) Add NFT_CHAIN_POLICY_UNSET to replace hardcoded -1 to
specify that the chain policy is unset. The chain policy
field is actually defined as an 8-bit unsigned integer.
2) Remove always true condition reported by smatch in
chain policy check.
3) Fix element lookup on dynamic sets, from Florian Westphal.
4) Use __u8 in ebtables uapi header, from Masahiro Yamada.
5) Bogus EBUSY when removing flowtable after chain flush,
from Laura Garcia Liebana.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks.
----------------------------------------------------------------
The following changes since commit 864668bfc374dfbf4851ec828b9049e08f9057b1:
selftests: Add test cases for `ip nexthop flush proto XX` (2019-09-19 18:35:55 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 9b05b6e11d5e93a3a517cadc12b9836e0470c255:
netfilter: nf_tables: bogus EBUSY when deleting flowtable after flush (2019-09-25 11:01:19 +0200)
----------------------------------------------------------------
Florian Westphal (1):
netfilter: nf_tables: allow lookups in dynamic sets
Laura Garcia Liebana (1):
netfilter: nf_tables: bogus EBUSY when deleting flowtable after flush
Masahiro Yamada (1):
netfilter: ebtables: use __u8 instead of uint8_t in uapi header
Pablo Neira Ayuso (2):
netfilter: nf_tables: add NFT_CHAIN_POLICY_UNSET and use it
netfilter: nf_tables_offload: fix always true policy is unset check
include/net/netfilter/nf_tables.h | 6 ++++++
include/uapi/linux/netfilter_bridge/ebtables.h | 6 +++---
net/netfilter/nf_tables_api.c | 25 ++++++++++++++++++++++---
net/netfilter/nf_tables_offload.c | 2 +-
net/netfilter/nft_flow_offload.c | 19 +++++++++++++++++++
net/netfilter/nft_lookup.c | 3 ---
usr/include/Makefile | 1 -
7 files changed, 51 insertions(+), 11 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2019-09-04 19:36 Pablo Neira Ayuso
@ 2019-09-04 22:04 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2019-09-04 22:04 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Wed, 4 Sep 2019 21:36:41 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) br_netfilter drops IPv6 packets if ipv6 is disabled, from Leonardo Bras.
>
> 2) nft_socket hits BUG() due to illegal skb->sk caching, patch from
> Fernando Fernandez Mancera.
>
> 3) nft_fib_netdev could be called with ipv6 disabled, leading to crash
> in the fib lookup, also from Leonardo.
>
> 4) ctnetlink honors IPS_OFFLOAD flag, just like nf_conntrack sysctl does.
>
> 5) Properly set up flowtable entry timeout, otherwise immediate
> removal by garbage collector might occur.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2019-09-04 19:36 Pablo Neira Ayuso
2019-09-04 22:04 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2019-09-04 19:36 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi,
The following patchset contains Netfilter fixes for net:
1) br_netfilter drops IPv6 packets if ipv6 is disabled, from Leonardo Bras.
2) nft_socket hits BUG() due to illegal skb->sk caching, patch from
Fernando Fernandez Mancera.
3) nft_fib_netdev could be called with ipv6 disabled, leading to crash
in the fib lookup, also from Leonardo.
4) ctnetlink honors IPS_OFFLOAD flag, just like nf_conntrack sysctl does.
5) Properly set up flowtable entry timeout, otherwise immediate
removal by garbage collector might occur.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks.
----------------------------------------------------------------
The following changes since commit e33b4325e60e146c2317a8b548cbd633239ff83b:
net: stmmac: dwmac-sun8i: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized (2019-09-02 11:48:15 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 110e48725db6262f260f10727d0fb2d3d25895e4:
netfilter: nf_flow_table: set default timeout after successful insertion (2019-09-03 22:55:42 +0200)
----------------------------------------------------------------
Fernando Fernandez Mancera (1):
netfilter: nft_socket: fix erroneous socket assignment
Leonardo Bras (2):
netfilter: bridge: Drops IPv6 packets if IPv6 module is not loaded
netfilter: nft_fib_netdev: Terminate rule eval if protocol=IPv6 and ipv6 module is disabled
Pablo Neira Ayuso (2):
netfilter: ctnetlink: honor IPS_OFFLOAD flag
netfilter: nf_flow_table: set default timeout after successful insertion
net/bridge/br_netfilter_hooks.c | 4 ++++
net/netfilter/nf_conntrack_netlink.c | 7 +++++--
net/netfilter/nf_flow_table_core.c | 2 +-
net/netfilter/nft_fib_netdev.c | 3 +++
net/netfilter/nft_socket.c | 6 +++---
5 files changed, 16 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2019-08-30 12:06 Pablo Neira Ayuso
@ 2019-08-31 0:52 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2019-08-31 0:52 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Fri, 30 Aug 2019 14:06:59 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Spurious warning when loading rules using the physdev match,
> from Todd Seidelmann.
>
> 2) Fix FTP conntrack helper debugging output, from Thomas Jarosch.
>
> 3) Restore per-netns nf_conntrack_{acct,helper,timeout} sysctl knobs,
> from Florian Westphal.
>
> 4) Clear skbuff timestamp from the flowtable datapath, also from Florian.
>
> 5) Fix incorrect byteorder of NFT_META_BRI_IIFVPROTO, from wenxu.
Pulled, thanks.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2019-08-30 12:06 Pablo Neira Ayuso
2019-08-31 0:52 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2019-08-30 12:06 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi,
The following patchset contains Netfilter fixes for net:
1) Spurious warning when loading rules using the physdev match,
from Todd Seidelmann.
2) Fix FTP conntrack helper debugging output, from Thomas Jarosch.
3) Restore per-netns nf_conntrack_{acct,helper,timeout} sysctl knobs,
from Florian Westphal.
4) Clear skbuff timestamp from the flowtable datapath, also from Florian.
5) Fix incorrect byteorder of NFT_META_BRI_IIFVPROTO, from wenxu.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks.
----------------------------------------------------------------
The following changes since commit f53a7ad189594a112167efaf17ea8d0242b5ac00:
r8152: Set memory to all 0xFFs on failed reg reads (2019-08-25 19:52:59 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to daf1de9078792a4d60e36aa7ecf3aadca65277c2:
netfilter: nft_meta_bridge: Fix get NFT_META_BRI_IIFVPROTO in network byteorder (2019-08-30 02:49:04 +0200)
----------------------------------------------------------------
Florian Westphal (2):
netfilter: conntrack: make sysctls per-namespace again
netfilter: nf_flow_table: clear skb tstamp before xmit
Thomas Jarosch (1):
netfilter: nf_conntrack_ftp: Fix debug output
Todd Seidelmann (1):
netfilter: xt_physdev: Fix spurious error message in physdev_mt_check
wenxu (1):
netfilter: nft_meta_bridge: Fix get NFT_META_BRI_IIFVPROTO in network byteorder
net/bridge/netfilter/nft_meta_bridge.c | 2 +-
net/netfilter/nf_conntrack_ftp.c | 2 +-
net/netfilter/nf_conntrack_standalone.c | 5 +++++
net/netfilter/nf_flow_table_ip.c | 3 ++-
net/netfilter/xt_physdev.c | 6 ++----
5 files changed, 11 insertions(+), 7 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2019-08-19 18:49 Pablo Neira Ayuso
@ 2019-08-19 20:16 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2019-08-19 20:16 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 19 Aug 2019 20:49:06 +0200
> The following patchset contains Netfilter fixes for net:
>
> 1) Remove IP MASQUERADING record in MAINTAINERS file,
> from Denis Efremov.
>
> 2) Counter arguments are swapped in ebtables, from
> Todd Seidelmann.
>
> 3) Missing netlink attribute validation in flow_offload
> extension.
>
> 4) Incorrect alignment in xt_nfacct that breaks 32-bits
> userspace / 64-bits kernels, from Juliana Rodrigueiro.
>
> 5) Missing include guard in nf_conntrack_h323_types.h,
> from Masahiro Yamada.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2019-08-19 18:49 Pablo Neira Ayuso
2019-08-19 20:16 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2019-08-19 18:49 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi,
The following patchset contains Netfilter fixes for net:
1) Remove IP MASQUERADING record in MAINTAINERS file,
from Denis Efremov.
2) Counter arguments are swapped in ebtables, from
Todd Seidelmann.
3) Missing netlink attribute validation in flow_offload
extension.
4) Incorrect alignment in xt_nfacct that breaks 32-bits
userspace / 64-bits kernels, from Juliana Rodrigueiro.
5) Missing include guard in nf_conntrack_h323_types.h,
from Masahiro Yamada.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks.
----------------------------------------------------------------
The following changes since commit cfef46d692efd852a0da6803f920cc756eea2855:
ravb: Fix use-after-free ravb_tstamp_skb (2019-08-18 14:19:14 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 38a429c898ddd210cc35463b096389f97c3c5a73:
netfilter: add include guard to nf_conntrack_h323_types.h (2019-08-19 13:59:57 +0200)
----------------------------------------------------------------
Denis Efremov (1):
MAINTAINERS: Remove IP MASQUERADING record
Juliana Rodrigueiro (1):
netfilter: xt_nfacct: Fix alignment mismatch in xt_nfacct_match_info
Masahiro Yamada (1):
netfilter: add include guard to nf_conntrack_h323_types.h
Pablo Neira Ayuso (1):
netfilter: nft_flow_offload: missing netlink attribute policy
Todd Seidelmann (1):
netfilter: ebtables: Fix argument order to ADD_COUNTER
MAINTAINERS | 5 ----
include/linux/netfilter/nf_conntrack_h323_types.h | 5 ++++
include/uapi/linux/netfilter/xt_nfacct.h | 5 ++++
net/bridge/netfilter/ebtables.c | 8 ++---
net/netfilter/nft_flow_offload.c | 6 ++++
net/netfilter/xt_nfacct.c | 36 ++++++++++++++++-------
6 files changed, 45 insertions(+), 20 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2019-03-11 22:50 Pablo Neira Ayuso
@ 2019-03-11 23:14 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2019-03-11 23:14 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 11 Mar 2019 23:50:30 +0100
> The following patchset contains Netfilter fixes for your net tree:
>
> 1) Fix list corruption in device notifier in the masquerade
> infrastructure, from Florian Westphal.
>
> 2) Fix double-free of sets and use-after-free when deleting elements.
>
> 3) Don't bogusly return EBUSY when removing a set after flush command.
>
> 4) Use-after-free in dynamically allocate operations.
>
> 5) Don't report a new ruleset generation to userspace if transaction
> list is empty, this invalidates the userspace cache innecessarily.
> From Florian Westphal.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks Pablo.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2019-03-11 22:50 Pablo Neira Ayuso
2019-03-11 23:14 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2019-03-11 22:50 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi David,
The following patchset contains Netfilter fixes for your net tree:
1) Fix list corruption in device notifier in the masquerade
infrastructure, from Florian Westphal.
2) Fix double-free of sets and use-after-free when deleting elements.
3) Don't bogusly return EBUSY when removing a set after flush command.
4) Use-after-free in dynamically allocate operations.
5) Don't report a new ruleset generation to userspace if transaction
list is empty, this invalidates the userspace cache innecessarily.
From Florian Westphal.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks!
----------------------------------------------------------------
The following changes since commit 1e027960edfaa6a43f9ca31081729b716598112b:
net/hsr: fix possible crash in add_timer() (2019-03-07 11:02:08 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to b8b27498659c65034032af79842913844a6cc79a:
netfilter: nf_tables: return immediately on empty commit (2019-03-11 20:01:20 +0100)
----------------------------------------------------------------
Florian Westphal (2):
netfilter: nat: don't register device notifier twice
netfilter: nf_tables: return immediately on empty commit
Pablo Neira Ayuso (3):
netfilter: nf_tables: fix set double-free in abort path
netfilter: nf_tables: bogus EBUSY when deleting set after flush
netfilter: nf_tables: use-after-free in dynamic operations
include/net/netfilter/nf_tables.h | 12 ++++++---
net/netfilter/nf_nat_masquerade.c | 35 +++++++++++++------------
net/netfilter/nf_tables_api.c | 54 +++++++++++++++++++++++++++++++++------
net/netfilter/nft_dynset.c | 13 +++++++---
net/netfilter/nft_lookup.c | 13 +++++++---
net/netfilter/nft_objref.c | 13 +++++++---
6 files changed, 100 insertions(+), 40 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2018-12-13 1:06 Pablo Neira Ayuso
@ 2018-12-13 5:37 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2018-12-13 5:37 UTC (permalink / raw)
Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 13 Dec 2018 02:06:26 +0100
> The following patchset contains Netfilter fixes for net:
>
> 1) Fix warnings suspicious rcu usage when handling base chain
> statistics, from Taehee Yoo.
>
> 2) Refetch pointer to tcp header from nf_ct_sack_adjust() since
> skb_make_writable() may reallocate data area, reported by Google
> folks patch from Florian.
>
> 3) Incorrect netlink nest end after previous cancellation from error
> path in ipset, from Pan Bian.
>
> 4) Use dst_hold_safe() from nf_xfrm_me_harder(), from Florian.
>
> 5) Use rb_link_node_rcu() for rcu-protected rbtree node in
> nf_conncount, from Taehee Yoo.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2018-12-13 1:06 Pablo Neira Ayuso
2018-12-13 5:37 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2018-12-13 1:06 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi David,
The following patchset contains Netfilter fixes for net:
1) Fix warnings suspicious rcu usage when handling base chain
statistics, from Taehee Yoo.
2) Refetch pointer to tcp header from nf_ct_sack_adjust() since
skb_make_writable() may reallocate data area, reported by Google
folks patch from Florian.
3) Incorrect netlink nest end after previous cancellation from error
path in ipset, from Pan Bian.
4) Use dst_hold_safe() from nf_xfrm_me_harder(), from Florian.
5) Use rb_link_node_rcu() for rcu-protected rbtree node in
nf_conncount, from Taehee Yoo.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks!
----------------------------------------------------------------
The following changes since commit 986103e7920cabc0b910749e77ae5589d3934d52:
net/ibmvnic: Fix RTNL deadlock during device reset (2018-12-03 15:53:55 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to d4e7df16567b80836a78d31b42f1a9355a636d67:
netfilter: nf_conncount: use rb_link_node_rcu() instead of rb_link_node() (2018-12-13 01:14:58 +0100)
----------------------------------------------------------------
Florian Westphal (2):
netfilter: seqadj: re-load tcp header pointer after possible head reallocation
netfilter: nat: can't use dst_hold on noref dst
Pan Bian (1):
netfilter: ipset: do not call ipset_nest_end after nla_nest_cancel
Taehee Yoo (2):
netfilter: nf_tables: fix suspicious RCU usage in nft_chain_stats_replace()
netfilter: nf_conncount: use rb_link_node_rcu() instead of rb_link_node()
include/linux/netfilter/nfnetlink.h | 12 ------------
net/netfilter/ipset/ip_set_list_set.c | 2 +-
net/netfilter/nf_conncount.c | 2 +-
net/netfilter/nf_conntrack_seqadj.c | 7 ++++---
net/netfilter/nf_nat_core.c | 3 ++-
net/netfilter/nf_tables_api.c | 21 +++++++++++++--------
net/netfilter/nf_tables_core.c | 2 +-
7 files changed, 22 insertions(+), 27 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2017-08-24 14:43 Pablo Neira Ayuso
@ 2017-08-24 18:49 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2017-08-24 18:49 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 24 Aug 2017 16:43:26 +0200
> The following patchset contains Netfilter fixes for your net tree,
> they are:
...
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2017-08-24 14:43 Pablo Neira Ayuso
2017-08-24 18:49 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2017-08-24 14:43 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi David,
The following patchset contains Netfilter fixes for your net tree,
they are:
1) Fix use after free of struct proc_dir_entry in ipt_CLUSTERIP, patch
from Sabrina Dubroca.
2) Fix spurious EINVAL errors from iptables over nft compatibility layer.
3) Reload pointer to ip header only if there is non-terminal verdict,
ie. XT_CONTINUE, otherwise invalid memory access may happen, patch
from Taehee Yoo.
4) Fix interaction between SYNPROXY and NAT, SYNPROXY adds sequence
adjustment already, however from nf_nat_setup() assumes there's not.
Patch from Xin Long.
5) Fix burst arithmetics in nft_limit as Joe Stringer mentioned during
NFWS in Faro. Patch from Andy Zhou.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks a lot!
----------------------------------------------------------------
The following changes since commit 073dd5ad34b1d3aaadaa7e5e8cbe576d9545f163:
netfilter: fix netfilter_net_init() return (2017-07-18 14:50:28 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to c26844eda9d4fdbd266660e3b3de2d0270e3a1ed:
netfilter: nf_tables: Fix nft limit burst handling (2017-08-24 16:23:17 +0200)
----------------------------------------------------------------
Pablo Neira Ayuso (1):
netfilter: nft_compat: check extension hook mask only if set
Sabrina Dubroca (1):
netfilter: ipt_CLUSTERIP: fix use-after-free of proc entry
Taehee Yoo (1):
netfilter: x_tables: Fix use-after-free in ipt_do_table.
Xin Long (1):
netfilter: check for seqadj ext existence before adding it in nf_nat_setup_info
andy zhou (1):
netfilter: nf_tables: Fix nft limit burst handling
net/ipv4/netfilter/arp_tables.c | 10 +++++-----
net/ipv4/netfilter/ip_tables.c | 9 +++++----
net/ipv4/netfilter/ipt_CLUSTERIP.c | 4 +++-
net/netfilter/nf_nat_core.c | 2 +-
net/netfilter/nft_compat.c | 4 ++--
net/netfilter/nft_limit.c | 25 ++++++++++++++-----------
6 files changed, 30 insertions(+), 24 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2017-07-18 21:11 ` Florian Westphal
@ 2017-07-18 21:54 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2017-07-18 21:54 UTC (permalink / raw)
To: fw; +Cc: pablo, netfilter-devel, netdev
From: Florian Westphal <fw@strlen.de>
Date: Tue, 18 Jul 2017 23:11:57 +0200
> David Miller <davem@davemloft.net> wrote:
>> What about that change Eric Dumazet was talking about with Florian
>> that stopped instantiating conntrack by default in new namespaces?
>
> Seems more appropriate for -next. If you prefer net instead, let me know
> and I'll get to work.
Yeah it's more on the -next side, albeit annoying.
Ok, so nevermind :)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2017-07-18 19:03 ` David Miller
@ 2017-07-18 21:11 ` Florian Westphal
2017-07-18 21:54 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Florian Westphal @ 2017-07-18 21:11 UTC (permalink / raw)
To: David Miller; +Cc: pablo, netfilter-devel, netdev
David Miller <davem@davemloft.net> wrote:
> What about that change Eric Dumazet was talking about with Florian
> that stopped instantiating conntrack by default in new namespaces?
Seems more appropriate for -next. If you prefer net instead, let me know
and I'll get to work.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2017-07-18 10:13 Pablo Neira Ayuso
@ 2017-07-18 19:03 ` David Miller
2017-07-18 21:11 ` Florian Westphal
0 siblings, 1 reply; 33+ messages in thread
From: David Miller @ 2017-07-18 19:03 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 18 Jul 2017 12:13:54 +0200
> The following patchset contains Netfilter fixes for your net tree,
> they are:
>
> 1) Missing netlink message sanity check in nfnetlink, patch from
> Mateusz Jurczyk.
>
> 2) We now have netfilter per-netns hooks, so let's kill global hook
> infrastructure, this infrastructure is known to be racy with netns.
> We don't care about out of tree modules. Patch from Florian Westphal.
>
> 3) find_appropriate_src() is buggy when colissions happens after the
> conversion of the nat bysource to rhashtable. Also from Florian.
>
> 4) Remove forward chain in nf_tables arp family, it's useless and it is
> causing quite a bit of confusion, from Florian Westphal.
>
> 5) nf_ct_remove_expect() is called with the wrong parameter, causing
> kernel oops, patch from Florian Westphal.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks a lot.
What about that change Eric Dumazet was talking about with Florian
that stopped instantiating conntrack by default in new namespaces?
Just curious.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2017-07-18 10:13 Pablo Neira Ayuso
2017-07-18 19:03 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2017-07-18 10:13 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi David,
The following patchset contains Netfilter fixes for your net tree,
they are:
1) Missing netlink message sanity check in nfnetlink, patch from
Mateusz Jurczyk.
2) We now have netfilter per-netns hooks, so let's kill global hook
infrastructure, this infrastructure is known to be racy with netns.
We don't care about out of tree modules. Patch from Florian Westphal.
3) find_appropriate_src() is buggy when colissions happens after the
conversion of the nat bysource to rhashtable. Also from Florian.
4) Remove forward chain in nf_tables arp family, it's useless and it is
causing quite a bit of confusion, from Florian Westphal.
5) nf_ct_remove_expect() is called with the wrong parameter, causing
kernel oops, patch from Florian Westphal.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks!
----------------------------------------------------------------
The following changes since commit 533da29b584de5ae0e9dafafbe52809f59cb5300:
Merge branch 'bcmgenet-Fragmented-SKB-corrections' (2017-07-15 21:29:08 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD
for you to fetch changes up to 36ac344e16e04e3e55e8fed7446095a6458c64e6:
netfilter: expect: fix crash when putting uninited expectation (2017-07-17 17:03:12 +0200)
----------------------------------------------------------------
Florian Westphal (4):
netfilter: remove old pre-netns era hook api
netfilter: nat: fix src map lookup
netfilter: nf_tables: only allow in/output for arp packets
netfilter: expect: fix crash when putting uninited expectation
Mateusz Jurczyk (1):
netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv
include/linux/netfilter.h | 9 ---
net/ipv4/netfilter/nf_tables_arp.c | 3 +-
net/netfilter/core.c | 143 ------------------------------------
net/netfilter/nf_conntrack_expect.c | 2 +-
net/netfilter/nf_nat_core.c | 17 +++--
net/netfilter/nfnetlink.c | 6 +-
6 files changed, 14 insertions(+), 166 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 0/5] Netfilter fixes for net
2015-08-10 17:58 Pablo Neira Ayuso
@ 2015-08-11 4:08 ` David Miller
0 siblings, 0 replies; 33+ messages in thread
From: David Miller @ 2015-08-11 4:08 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 10 Aug 2015 19:58:34 +0200
> The following patchset contains five Netfilter fixes for your net tree,
> they are:
>
> 1) Silence a warning on falling back to vmalloc(). Since 88eab472ec21, we can
> easily hit this warning message, that gets users confused. So let's get rid
> of it.
>
> 2) Recently when porting the template object allocation on top of kmalloc to
> fix the netns dependencies between x_tables and conntrack, the error
> checks where left unchanged. Remove IS_ERR() and check for NULL instead.
> Patch from Dan Carpenter.
>
> 3) Don't ignore gfp_flags in the new nf_ct_tmpl_alloc() function, from
> Joe Stringer.
>
> 4) Fix a crash due to NULL pointer dereference in ip6t_SYNPROXY, patch from
> Phil Sutter.
>
> 5) The sequence number of the Syn+ack that is sent from SYNPROXY to clients is
> not adjusted through our NAT infrastructure, as a result the client may
> ignore this TCP packet and TCP flow hangs until the client probes us. Also
> from Phil Sutter.
>
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Pulled, thanks Pablo.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 0/5] Netfilter fixes for net
@ 2015-08-10 17:58 Pablo Neira Ayuso
2015-08-11 4:08 ` David Miller
0 siblings, 1 reply; 33+ messages in thread
From: Pablo Neira Ayuso @ 2015-08-10 17:58 UTC (permalink / raw)
To: netfilter-devel; +Cc: davem, netdev
Hi David,
The following patchset contains five Netfilter fixes for your net tree,
they are:
1) Silence a warning on falling back to vmalloc(). Since 88eab472ec21, we can
easily hit this warning message, that gets users confused. So let's get rid
of it.
2) Recently when porting the template object allocation on top of kmalloc to
fix the netns dependencies between x_tables and conntrack, the error
checks where left unchanged. Remove IS_ERR() and check for NULL instead.
Patch from Dan Carpenter.
3) Don't ignore gfp_flags in the new nf_ct_tmpl_alloc() function, from
Joe Stringer.
4) Fix a crash due to NULL pointer dereference in ip6t_SYNPROXY, patch from
Phil Sutter.
5) The sequence number of the Syn+ack that is sent from SYNPROXY to clients is
not adjusted through our NAT infrastructure, as a result the client may
ignore this TCP packet and TCP flow hangs until the client probes us. Also
from Phil Sutter.
You can pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
Thanks!
----------------------------------------------------------------
The following changes since commit 15f1bb1f1e067be7088ed43ef23d59629bd24348:
qlcnic: Fix corruption while copying (2015-07-29 23:57:26 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
for you to fetch changes up to 3c16241c445303a90529565e7437e1f240acfef2:
netfilter: SYNPROXY: fix sending window update to client (2015-08-10 13:55:07 +0200)
----------------------------------------------------------------
Dan Carpenter (1):
netfilter: nf_conntrack: checking for IS_ERR() instead of NULL
Joe Stringer (1):
netfilter: conntrack: Use flags in nf_ct_tmpl_alloc()
Pablo Neira Ayuso (1):
netfilter: nf_conntrack: silence warning on falling back to vmalloc()
Phil Sutter (2):
netfilter: ip6t_SYNPROXY: fix NULL pointer dereference
netfilter: SYNPROXY: fix sending window update to client
net/ipv4/netfilter/ipt_SYNPROXY.c | 3 ++-
net/ipv6/netfilter/ip6t_SYNPROXY.c | 19 +++++++++++--------
net/netfilter/nf_conntrack_core.c | 8 +++-----
net/netfilter/nf_synproxy_core.c | 4 +---
net/netfilter/xt_CT.c | 5 +++--
5 files changed, 20 insertions(+), 19 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2020-09-09 3:08 UTC | newest]
Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 15:09 [PATCH 0/5] Netfilter fixes for net Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 1/5] netfilter: ctnetlink: add a range check for l3/l4 protonum Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 2/5] netfilter: nf_tables: coalesce multiple notifications into one skbuff Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 3/5] netfilter: ctnetlink: fix mark based dump filtering regression Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 4/5] netfilter: conntrack: nf_conncount_init is failing with IPv6 disabled Pablo Neira Ayuso
2020-09-08 15:09 ` [PATCH 5/5] netfilter: nft_meta: use socket user_ns to retrieve skuid and skgid Pablo Neira Ayuso
2020-09-09 3:08 ` [PATCH 0/5] Netfilter fixes for net David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-08-04 20:02 Pablo Neira Ayuso
2020-08-04 20:32 ` David Miller
2020-05-25 21:54 Pablo Neira Ayuso
2020-05-26 1:29 ` David Miller
2020-05-26 20:10 ` Pablo Neira Ayuso
2020-05-26 23:08 ` David Miller
2019-09-25 20:29 Pablo Neira Ayuso
2019-09-27 18:16 ` David Miller
2019-09-04 19:36 Pablo Neira Ayuso
2019-09-04 22:04 ` David Miller
2019-08-30 12:06 Pablo Neira Ayuso
2019-08-31 0:52 ` David Miller
2019-08-19 18:49 Pablo Neira Ayuso
2019-08-19 20:16 ` David Miller
2019-03-11 22:50 Pablo Neira Ayuso
2019-03-11 23:14 ` David Miller
2018-12-13 1:06 Pablo Neira Ayuso
2018-12-13 5:37 ` David Miller
2017-08-24 14:43 Pablo Neira Ayuso
2017-08-24 18:49 ` David Miller
2017-07-18 10:13 Pablo Neira Ayuso
2017-07-18 19:03 ` David Miller
2017-07-18 21:11 ` Florian Westphal
2017-07-18 21:54 ` David Miller
2015-08-10 17:58 Pablo Neira Ayuso
2015-08-11 4:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).