* [PATCH net V2] netfilter: Drop fragmented ndisc packets assembled in netfilter
@ 2020-10-13 12:23 Georg Kohmann
2020-10-20 15:20 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Georg Kohmann @ 2020-10-13 12:23 UTC (permalink / raw)
To: netdev
Cc: netfilter-devel, pablo, kadlec, fw, davem, kuznet, yoshfuji,
kuba, Georg Kohmann
Fragmented ndisc packets assembled in netfilter not dropped as specified
in RFC 6980, section 5. This behaviour breaks TAHI IPv6 Core Conformance
Tests v6LC.2.1.22/23, V6LC.2.2.26/27 and V6LC.2.3.18.
Setting IP6SKB_FRAGMENTED flag during reassembly.
References: commit b800c3b966bc ("ipv6: drop fragmented ndisc packets by
default (RFC 6980)")
Signed-off-by: Georg Kohmann <geokohma@cisco.com>
---
V2: Fix spelling of IPSKB_FRAGMENTED to IP6SKB_FRAGMENTED in comment
net/ipv6/netfilter/nf_conntrack_reasm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c
index fed9666..054d287 100644
--- a/net/ipv6/netfilter/nf_conntrack_reasm.c
+++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
@@ -355,6 +355,7 @@ static int nf_ct_frag6_reasm(struct frag_queue *fq, struct sk_buff *skb,
ipv6_hdr(skb)->payload_len = htons(payload_len);
ipv6_change_dsfield(ipv6_hdr(skb), 0xff, ecn);
IP6CB(skb)->frag_max_size = sizeof(struct ipv6hdr) + fq->q.max_size;
+ IP6CB(skb)->flags |= IP6SKB_FRAGMENTED;
/* Yes, and fold redundant checksum back. 8) */
if (skb->ip_summed == CHECKSUM_COMPLETE)
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net V2] netfilter: Drop fragmented ndisc packets assembled in netfilter
2020-10-13 12:23 [PATCH net V2] netfilter: Drop fragmented ndisc packets assembled in netfilter Georg Kohmann
@ 2020-10-20 15:20 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2020-10-20 15:20 UTC (permalink / raw)
To: Georg Kohmann
Cc: netdev, netfilter-devel, kadlec, fw, davem, kuznet, yoshfuji, kuba
On Tue, Oct 13, 2020 at 02:23:12PM +0200, Georg Kohmann wrote:
> Fragmented ndisc packets assembled in netfilter not dropped as specified
> in RFC 6980, section 5. This behaviour breaks TAHI IPv6 Core Conformance
> Tests v6LC.2.1.22/23, V6LC.2.2.26/27 and V6LC.2.3.18.
>
> Setting IP6SKB_FRAGMENTED flag during reassembly.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13 12:23 [PATCH net V2] netfilter: Drop fragmented ndisc packets assembled in netfilter Georg Kohmann
2020-10-20 15:20 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).