From: Lukas Wunner <lukas@wunner.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>,
coreteam@netfilter.org,
Network Development <netdev@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>, Thomas Graf <tgraf@suug.ch>,
Laura Garcia Liebana <nevola@gmail.com>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH nf-next v4 5/5] af_packet: Introduce egress hook
Date: Sun, 24 Jan 2021 12:14:32 +0100 [thread overview]
Message-ID: <20210124111432.GC1056@wunner.de> (raw)
In-Reply-To: <CA+FuTSfuLfh3H45HnvtJPocxj+E7maGwzkgYsfktna2+cJi9zQ@mail.gmail.com>
On Fri, Jan 22, 2021 at 11:13:19AM -0500, Willem de Bruijn wrote:
> On Fri, Jan 22, 2021 at 4:44 AM Lukas Wunner <lukas@wunner.de> wrote:
> > Add egress hook for AF_PACKET sockets that have the PACKET_QDISC_BYPASS
> > socket option set to on, which allows packets to escape without being
> > filtered in the egress path.
> >
> > This patch only updates the AF_PACKET path, it does not update
> > dev_direct_xmit() so the XDP infrastructure has a chance to bypass
> > Netfilter.
>
> Isn't the point of PACKET_QDISC_BYPASS to skip steps like this?
I suppose PACKET_QDISC_BYPASS "was introduced to bypass qdisc,
not to bypass everything."
(The quote is taken from this message by Eric Dumazet:
https://lore.kernel.org/netfilter-devel/a9006cf7-f4ba-81b1-fca1-fd2e97939fdc@gmail.com/
)
Thanks,
Lukas
next prev parent reply other threads:[~2021-01-24 11:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:47 [PATCH nf-next v4 0/5] Netfilter egress hook Lukas Wunner
2021-01-22 8:47 ` [PATCH nf-next v4 1/5] net: sched: Micro-optimize egress handling Lukas Wunner
2021-01-22 9:40 ` Eric Dumazet
2021-01-24 10:33 ` Lukas Wunner
2021-01-25 19:39 ` Jakub Kicinski
2021-01-26 8:58 ` Dan Carpenter
2021-01-30 16:00 ` Lukas Wunner
2021-01-24 3:26 ` Jakub Kicinski
2021-01-24 10:46 ` Lukas Wunner
2021-01-22 8:47 ` [PATCH nf-next v4 2/5] netfilter: Rename ingress hook include file Lukas Wunner
2021-01-22 8:47 ` [PATCH nf-next v4 3/5] netfilter: Generalize " Lukas Wunner
2021-01-22 8:47 ` [PATCH nf-next v4 4/5] netfilter: Introduce egress hook Lukas Wunner
2021-01-26 19:13 ` Daniel Borkmann
2021-09-11 21:26 ` Lukas Wunner
2021-09-15 9:45 ` Daniel Borkmann
2021-01-22 8:47 ` [PATCH nf-next v4 5/5] af_packet: " Lukas Wunner
2021-01-22 16:13 ` Willem de Bruijn
2021-01-24 11:14 ` Lukas Wunner [this message]
2021-01-24 16:18 ` Willem de Bruijn
2021-01-30 16:26 ` Lukas Wunner
2021-01-30 16:58 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124111432.GC1056@wunner.de \
--to=lukas@wunner.de \
--cc=ast@kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=john.fastabend@gmail.com \
--cc=kadlec@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nevola@gmail.com \
--cc=pablo@netfilter.org \
--cc=tgraf@suug.ch \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).