From: Simon Horman <horms@verge.net.au>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: netfilter-devel@vger.kernel.org, ja@ssi.bg
Subject: Re: [PATCH nf] ipvs: check that ip_vs_conn_tab_bits is between 8 and 20
Date: Fri, 10 Sep 2021 20:39:53 +0200 [thread overview]
Message-ID: <20210910183953.GB19514@vergenet.net> (raw)
In-Reply-To: <86eabeb9dd62aebf1e2533926fdd13fed48bab1f.1631289960.git.aclaudi@redhat.com>
On Fri, Sep 10, 2021 at 06:08:39PM +0200, Andrea Claudi wrote:
> ip_vs_conn_tab_bits may be provided by the user through the
> conn_tab_bits module parameter. If this value is greater than 31, or
> less than 0, the shift operator used to derive tab_size causes undefined
> behaviour.
>
> Fix this checking ip_vs_conn_tab_bits value to be in the range specified
> in ipvs Kconfig. If not, simply use default value.
>
> Fixes: 6f7edb4881bf ("IPVS: Allow boot time change of hash size")
> Reported-by: Yi Chen <yiche@redhat.com>
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Acked-by: Simon Horman <horms@verge.net.au>
next prev parent reply other threads:[~2021-09-10 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:08 [PATCH nf] ipvs: check that ip_vs_conn_tab_bits is between 8 and 20 Andrea Claudi
2021-09-10 17:32 ` Julian Anastasov
2021-09-10 18:39 ` Simon Horman [this message]
2021-09-13 22:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910183953.GB19514@vergenet.net \
--to=horms@verge.net.au \
--cc=aclaudi@redhat.com \
--cc=ja@ssi.bg \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).