From: Julian Anastasov <ja@ssi.bg>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: netfilter-devel@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nf] ipvs: check that ip_vs_conn_tab_bits is between 8 and 20
Date: Fri, 10 Sep 2021 20:32:40 +0300 (EEST) [thread overview]
Message-ID: <b328e7e8-973-b4dc-d912-81d8d7661681@ssi.bg> (raw)
In-Reply-To: <86eabeb9dd62aebf1e2533926fdd13fed48bab1f.1631289960.git.aclaudi@redhat.com>
Hello,
On Fri, 10 Sep 2021, Andrea Claudi wrote:
> ip_vs_conn_tab_bits may be provided by the user through the
> conn_tab_bits module parameter. If this value is greater than 31, or
> less than 0, the shift operator used to derive tab_size causes undefined
> behaviour.
>
> Fix this checking ip_vs_conn_tab_bits value to be in the range specified
> in ipvs Kconfig. If not, simply use default value.
>
> Fixes: 6f7edb4881bf ("IPVS: Allow boot time change of hash size")
> Reported-by: Yi Chen <yiche@redhat.com>
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Looks good to me, thanks!
Acked-by: Julian Anastasov <ja@ssi.bg>
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index c100c6b112c8..2c467c422dc6 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1468,6 +1468,10 @@ int __init ip_vs_conn_init(void)
> int idx;
>
> /* Compute size and mask */
> + if (ip_vs_conn_tab_bits < 8 || ip_vs_conn_tab_bits > 20) {
> + pr_info("conn_tab_bits not in [8, 20]. Using default value\n");
> + ip_vs_conn_tab_bits = CONFIG_IP_VS_TAB_BITS;
> + }
> ip_vs_conn_tab_size = 1 << ip_vs_conn_tab_bits;
> ip_vs_conn_tab_mask = ip_vs_conn_tab_size - 1;
>
> --
> 2.31.1
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2021-09-10 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:08 [PATCH nf] ipvs: check that ip_vs_conn_tab_bits is between 8 and 20 Andrea Claudi
2021-09-10 17:32 ` Julian Anastasov [this message]
2021-09-10 18:39 ` Simon Horman
2021-09-13 22:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b328e7e8-973-b4dc-d912-81d8d7661681@ssi.bg \
--to=ja@ssi.bg \
--cc=aclaudi@redhat.com \
--cc=horms@verge.net.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).