From: Phil Sutter <phil@nwl.cc>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: [ipset PATCH 0/4] Some testsuite improvements
Date: Tue, 7 Mar 2023 14:58:08 +0100 [thread overview]
Message-ID: <20230307135812.25993-1-phil@nwl.cc> (raw)
Patch 1 fixes the reason why xlate testuite failed for me - it was
simply not testing the right binary. Make it adhere to what the regular
testsuite does by calling the built ipset tool instead of the installed
one.
Patch 2 is just bonus, the idea for it came from a "does this even work"
sanity check while debugging the above.
Patch 3 fixes for missing 'netmask' tool on my system. Not entirely
satisfying though, there's no 'sendip', either (but the testsuite may
run without).
Patch 4 avoids a spurious testsuite failure for me. Not sure if it's a
good solution or will just move the spurious failure to others' systems.
Phil Sutter (4):
tests: xlate: Test built binary by default
tests: xlate: Make test input valid
tests: cidr.sh: Add ipcalc fallback
tests: hash:ip,port.t: 'vrrp' is printed as 'carp'
tests/cidr.sh | 32 ++++++++++++++++++++++++++++----
tests/hash:ip,port.t.list2 | 2 +-
tests/xlate/ipset-translate | 1 +
tests/xlate/runtest.sh | 14 ++++++++++----
tests/xlate/xlate.t | 6 +++---
tests/xlate/xlate.t.nft | 4 ++--
6 files changed, 45 insertions(+), 14 deletions(-)
create mode 120000 tests/xlate/ipset-translate
--
2.38.0
next reply other threads:[~2023-03-07 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 13:58 Phil Sutter [this message]
2023-03-07 13:58 ` [ipset PATCH 1/4] tests: xlate: Test built binary by default Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 2/4] tests: xlate: Make test input valid Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 3/4] tests: cidr.sh: Add ipcalc fallback Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 4/4] tests: hash:ip,port.t: 'vrrp' is printed as 'carp' Phil Sutter
2023-03-10 11:56 ` [ipset PATCH 0/4] Some testsuite improvements Pablo Neira Ayuso
2023-03-10 12:19 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307135812.25993-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).