From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [ipset PATCH 0/4] Some testsuite improvements
Date: Fri, 10 Mar 2023 12:56:03 +0100 [thread overview]
Message-ID: <ZAsa01H5FGddHC/a@salvia> (raw)
In-Reply-To: <20230307135812.25993-1-phil@nwl.cc>
On Tue, Mar 07, 2023 at 02:58:08PM +0100, Phil Sutter wrote:
> Patch 1 fixes the reason why xlate testuite failed for me - it was
> simply not testing the right binary. Make it adhere to what the regular
> testsuite does by calling the built ipset tool instead of the installed
> one.
>
> Patch 2 is just bonus, the idea for it came from a "does this even work"
> sanity check while debugging the above.
>
> Patch 3 fixes for missing 'netmask' tool on my system. Not entirely
> satisfying though, there's no 'sendip', either (but the testsuite may
> run without).
>
> Patch 4 avoids a spurious testsuite failure for me. Not sure if it's a
> good solution or will just move the spurious failure to others' systems.
LGTM
next prev parent reply other threads:[~2023-03-10 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 13:58 [ipset PATCH 0/4] Some testsuite improvements Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 1/4] tests: xlate: Test built binary by default Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 2/4] tests: xlate: Make test input valid Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 3/4] tests: cidr.sh: Add ipcalc fallback Phil Sutter
2023-03-07 13:58 ` [ipset PATCH 4/4] tests: hash:ip,port.t: 'vrrp' is printed as 'carp' Phil Sutter
2023-03-10 11:56 ` Pablo Neira Ayuso [this message]
2023-03-10 12:19 ` [ipset PATCH 0/4] Some testsuite improvements Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAsa01H5FGddHC/a@salvia \
--to=pablo@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).