netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH nft] include: json: add missing synproxy stmt print stub
@ 2019-07-18  9:41 Fernando Fernandez Mancera
  2019-07-18 10:01 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 3+ messages in thread
From: Fernando Fernandez Mancera @ 2019-07-18  9:41 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Fernando Fernandez Mancera

Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching")
Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
---
 include/json.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/json.h b/include/json.h
index ce57c9f..7f2df7c 100644
--- a/include/json.h
+++ b/include/json.h
@@ -180,6 +180,7 @@ STMT_PRINT_STUB(queue)
 STMT_PRINT_STUB(verdict)
 STMT_PRINT_STUB(connlimit)
 STMT_PRINT_STUB(tproxy)
+STMT_PRINT_STUB(synproxy)
 
 #undef STMT_PRINT_STUB
 #undef EXPR_PRINT_STUB
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH nft] include: json: add missing synproxy stmt print stub
  2019-07-18  9:41 [PATCH nft] include: json: add missing synproxy stmt print stub Fernando Fernandez Mancera
@ 2019-07-18 10:01 ` Pablo Neira Ayuso
  2019-07-18 10:07   ` Fernando Fernandez Mancera
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2019-07-18 10:01 UTC (permalink / raw)
  To: Fernando Fernandez Mancera; +Cc: netfilter-devel

Hi Fernando,

On Thu, Jul 18, 2019 at 11:41:14AM +0200, Fernando Fernandez Mancera wrote:
> Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching")
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
> ---
>  include/json.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/json.h b/include/json.h
> index ce57c9f..7f2df7c 100644
> --- a/include/json.h
> +++ b/include/json.h
> @@ -180,6 +180,7 @@ STMT_PRINT_STUB(queue)
>  STMT_PRINT_STUB(verdict)
>  STMT_PRINT_STUB(connlimit)
>  STMT_PRINT_STUB(tproxy)
> +STMT_PRINT_STUB(synproxy)

I'm sure you need this, but how does this missing line manifests as a
problem?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH nft] include: json: add missing synproxy stmt print stub
  2019-07-18 10:01 ` Pablo Neira Ayuso
@ 2019-07-18 10:07   ` Fernando Fernandez Mancera
  0 siblings, 0 replies; 3+ messages in thread
From: Fernando Fernandez Mancera @ 2019-07-18 10:07 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: netfilter-devel

Hi Pablo,

On 7/18/19 12:01 PM, Pablo Neira Ayuso wrote:
> Hi Fernando,
> 
> On Thu, Jul 18, 2019 at 11:41:14AM +0200, Fernando Fernandez Mancera wrote:
>> Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching")
>> Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
>> ---
>>  include/json.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/json.h b/include/json.h
>> index ce57c9f..7f2df7c 100644
>> --- a/include/json.h
>> +++ b/include/json.h
>> @@ -180,6 +180,7 @@ STMT_PRINT_STUB(queue)
>>  STMT_PRINT_STUB(verdict)
>>  STMT_PRINT_STUB(connlimit)
>>  STMT_PRINT_STUB(tproxy)
>> +STMT_PRINT_STUB(synproxy)
> 
> I'm sure you need this, but how does this missing line manifests as a
> problem?
> 

When compiling nftables without json support I am getting the following
error.

statement.c:930:11: error: ‘synproxy_stmt_json’ undeclared here (not in
a function); did you mean ‘tproxy_stmt_json’?
  .json  = synproxy_stmt_json,
           ^~~~~~~~~~~~~~~~~~
           tproxy_stmt_json

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-18 10:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18  9:41 [PATCH nft] include: json: add missing synproxy stmt print stub Fernando Fernandez Mancera
2019-07-18 10:01 ` Pablo Neira Ayuso
2019-07-18 10:07   ` Fernando Fernandez Mancera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).