From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [ipset PATCH 0/2] Two minor code fixes
Date: Wed, 1 Mar 2023 23:28:36 +0100 [thread overview]
Message-ID: <Y//RlHWq86REFVu6@salvia> (raw)
In-Reply-To: <20230222170241.26208-1-phil@nwl.cc>
On Wed, Feb 22, 2023 at 06:02:39PM +0100, Phil Sutter wrote:
> These were identified by Coverity tool, no problems in practice. Still
> worth fixing to reduce noise in code checkers.
LGTM.
Did you run ipset xlate tests? These should not break those but just
in case.
next prev parent reply other threads:[~2023-03-01 22:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 17:02 [ipset PATCH 0/2] Two minor code fixes Phil Sutter
2023-02-22 17:02 ` [ipset PATCH 1/2] xlate: Fix for fd leak in error path Phil Sutter
2023-02-22 17:02 ` [ipset PATCH 2/2] xlate: Drop dead code Phil Sutter
2023-03-01 22:28 ` Pablo Neira Ayuso [this message]
2023-03-02 9:04 ` [ipset PATCH 0/2] Two minor code fixes Phil Sutter
2023-03-10 11:56 ` Pablo Neira Ayuso
2023-03-10 12:05 ` Phil Sutter
2023-03-10 12:22 ` Pablo Neira Ayuso
2023-03-10 12:37 ` Phil Sutter
2023-03-10 13:05 ` Pablo Neira Ayuso
2023-03-10 12:18 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y//RlHWq86REFVu6@salvia \
--to=pablo@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).