[PATCH libnetfilter_log] src: make nflog_open_nfnl() static

[PATCH libnetfilter_log] src: make nflog_open_nfnl() static

[Duncan Roe]

nflog_open_nfnl() is neither documented nor used outside the source file
wherin it is defined.
(ulogd doesn't use this function either).

Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
---
 include/libnetfilter_log/libnetfilter_log.h | 1 -
 src/libnetfilter_log.c                      | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/libnetfilter_log/libnetfilter_log.h b/include/libnetfilter_log/libnetfilter_log.h
index c27149f..771d203 100644
--- a/include/libnetfilter_log/libnetfilter_log.h
+++ b/include/libnetfilter_log/libnetfilter_log.h
@@ -32,7 +32,6 @@ typedef int nflog_callback(struct nflog_g_handle *gh, struct nfgenmsg *nfmsg,
 
 
 extern struct nflog_handle *nflog_open(void);
-extern struct nflog_handle *nflog_open_nfnl(struct nfnl_handle *nfnlh);
 extern int nflog_close(struct nflog_handle *h);
 
 extern int nflog_bind_pf(struct nflog_handle *h, uint16_t pf);
diff --git a/src/libnetfilter_log.c b/src/libnetfilter_log.c
index 546d667..7eada15 100644
--- a/src/libnetfilter_log.c
+++ b/src/libnetfilter_log.c
@@ -233,7 +233,7 @@ int nflog_fd(struct nflog_handle *h)
  * @}
  */
 
-struct nflog_handle *nflog_open_nfnl(struct nfnl_handle *nfnlh)
+static struct nflog_handle *nflog_open_nfnl(struct nfnl_handle *nfnlh)
 {
 	struct nflog_handle *h;
 	int err;
-- 
2.17.5

Re: [PATCH libnetfilter_log] src: make nflog_open_nfnl() static

[Pablo Neira Ayuso]

On Mon, Sep 13, 2021 at 03:57:49PM +1000, Duncan Roe wrote:
> nflog_open_nfnl() is neither documented nor used outside the source file
> wherin it is defined.
> (ulogd doesn't use this function either).

I'm afraid someone might be using it, even if it was never documented.