* [nft PATCH] tests: shell: Fix for maps/typeof_maps_add_delete with ASAN
@ 2024-04-24 21:59 Phil Sutter
2024-04-25 10:49 ` Phil Sutter
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2024-04-24 21:59 UTC (permalink / raw)
To: netfilter-devel
With both KASAN and ASAN enabled, my VM is too slow so the ping-induced
set entry times out before the test checks its existence. Increase its
timeout to 2s, seems to do the trick.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
.../testcases/maps/dumps/typeof_maps_add_delete.json-nft | 2 +-
tests/shell/testcases/maps/dumps/typeof_maps_add_delete.nft | 2 +-
tests/shell/testcases/maps/typeof_maps_add_delete | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.json-nft b/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.json-nft
index 8130c46c154cd..b3204a283d0ad 100644
--- a/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.json-nft
+++ b/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.json-nft
@@ -231,7 +231,7 @@
"elem": {
"elem": {
"val": "10.2.3.4",
- "timeout": 1
+ "timeout": 2
}
},
"data": 2,
diff --git a/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.nft b/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.nft
index 9134673cf48a1..e80366b8bf2a4 100644
--- a/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.nft
+++ b/tests/shell/testcases/maps/dumps/typeof_maps_add_delete.nft
@@ -16,7 +16,7 @@ table ip dynset {
chain input {
type filter hook input priority filter; policy accept;
- add @dynmark { 10.2.3.4 timeout 1s : 0x00000002 } comment "also check timeout-gc"
+ add @dynmark { 10.2.3.4 timeout 2s : 0x00000002 } comment "also check timeout-gc"
meta l4proto icmp ip daddr 127.0.0.42 jump test_ping
}
}
diff --git a/tests/shell/testcases/maps/typeof_maps_add_delete b/tests/shell/testcases/maps/typeof_maps_add_delete
index d2ac9f1ce8c92..2d718c5fecbf3 100755
--- a/tests/shell/testcases/maps/typeof_maps_add_delete
+++ b/tests/shell/testcases/maps/typeof_maps_add_delete
@@ -30,7 +30,7 @@ EXPECTED="table ip dynset {
chain input {
type filter hook input priority 0; policy accept;
- add @dynmark { 10.2.3.4 timeout 1s : 0x2 } comment \"also check timeout-gc\"
+ add @dynmark { 10.2.3.4 timeout 2s : 0x2 } comment \"also check timeout-gc\"
meta l4proto icmp ip daddr 127.0.0.42 jump test_ping
}
}"
@@ -45,7 +45,7 @@ ping -c 1 127.0.0.42
$NFT get element ip dynset dynmark { 10.2.3.4 }
# wait so that 10.2.3.4 times out.
-sleep 2
+sleep 3
set +e
$NFT get element ip dynset dynmark { 10.2.3.4 } && exit 1
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nft PATCH] tests: shell: Fix for maps/typeof_maps_add_delete with ASAN
2024-04-24 21:59 [nft PATCH] tests: shell: Fix for maps/typeof_maps_add_delete with ASAN Phil Sutter
@ 2024-04-25 10:49 ` Phil Sutter
0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2024-04-25 10:49 UTC (permalink / raw)
To: netfilter-devel
On Wed, Apr 24, 2024 at 11:59:52PM +0200, Phil Sutter wrote:
> With both KASAN and ASAN enabled, my VM is too slow so the ping-induced
> set entry times out before the test checks its existence. Increase its
> timeout to 2s, seems to do the trick.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-25 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-24 21:59 [nft PATCH] tests: shell: Fix for maps/typeof_maps_add_delete with ASAN Phil Sutter
2024-04-25 10:49 ` Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).