nouveau.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
@ 2021-01-15 18:15 Lee Jones
  2021-01-15 18:15 ` [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-15 18:15 UTC (permalink / raw)
  To: lee.jones
  Cc: David Airlie, nouveau, dri-devel, Eric Anholt, Jesse Barnes,
	Jan Safrata, Sumit Semwal, Gareth Hughes, Pei Zhang, Rob Clark,
	Min He, VMware Graphics, Ben Skeggs, Dave Airlie, Niu Bing,
	linux-media, jim liu, Thomas Zimmermann, Roland Scheidegger,
	intel-gfx, linaro-mm-sig, Maxime Ripard, intel-gvt-dev,
	Eddie Dong, linux-kernel, Faith

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Lee Jones (29):
  drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural
  drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation
    problems
  drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member
  drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and
    remove others
  drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'
  drm/gma500/mmu: Actually return an error if one occurs
  drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff'
    param
  drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function
    param descriptions
  drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another
  drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member
    'manager'
  drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses
  drm/gma500/psb_irq: Demote kernel-doc abuse
  drm/drm_dp_helper: Fix spelling issue and add missing description for
    'enable_frl_ready_hpd'
  drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in
    'cdv_intel_crt_detect_hotplug()'s header
  drm/gma500/cdv_intel_display: Demote kernel-doc abuse in
    'cdv_intel_panel_fitter_pipe()'s header
  drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks
    and fix another
  drm/gma500/cdv_intel_dp: Demote one unworthy header fix another
  drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp'
  drm/gma500/oaktrail_lvds: Demote one documentation header fix another
  drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers
  drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting
    abuses
  drm/gma500/mdfld_intel_display: Demote three kernel-doc formatting
    abuses
  drm/drm_agpsupport: Strip out obviously wrong descriptions and demote
    to standard headers
  drm/i915/gvt/handlers: Remove kernel-doc formatting from
    non-kernel-doc header
  drm/nouveau/nouveau_ioc32: File headers are not good candidates for
    kernel-doc
  drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void
    function
  drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from
    'nouveau_bios_init()'
  drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment
    block
  drm/vmwgfx/ttm_object: Reorder header to immediately precede its
    struct

 drivers/gpu/drm/drm_agpsupport.c             | 46 +++++---------------
 drivers/gpu/drm/drm_dp_helper.c              |  3 +-
 drivers/gpu/drm/gma500/cdv_intel_crt.c       |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_display.c   |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_dp.c        |  4 +-
 drivers/gpu/drm/gma500/cdv_intel_lvds.c      |  7 +--
 drivers/gpu/drm/gma500/mdfld_dsi_output.c    |  4 +-
 drivers/gpu/drm/gma500/mdfld_intel_display.c |  6 +--
 drivers/gpu/drm/gma500/mmu.c                 |  2 +-
 drivers/gpu/drm/gma500/oaktrail_crtc.c       |  6 +--
 drivers/gpu/drm/gma500/oaktrail_lvds.c       |  3 +-
 drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c   |  8 ++--
 drivers/gpu/drm/gma500/psb_intel_sdvo.c      |  6 +--
 drivers/gpu/drm/gma500/psb_irq.c             |  3 +-
 drivers/gpu/drm/i915/gvt/handlers.c          |  2 +-
 drivers/gpu/drm/nouveau/nouveau_bios.c       |  2 -
 drivers/gpu/drm/nouveau/nouveau_ioc32.c      |  4 +-
 drivers/gpu/drm/nouveau/nouveau_svm.c        |  5 +--
 drivers/gpu/drm/vmwgfx/ttm_object.c          | 25 ++++++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c      |  9 ++--
 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c         |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c       |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c      |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c          |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_so.c           |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_thp.c          |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c   |  5 ++-
 27 files changed, 74 insertions(+), 90 deletions(-)

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Eddie Dong <eddie.dong@intel.com>
Cc: Eric Anholt <eric@anholt.net>
Cc: Faith <faith@valinux.com>
Cc: Gareth Hughes <gareth@valinux.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: Jackie Li <yaodong.li@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jan Safrata <jan.nikitenko@gmail.com>
Cc: Jesse Barnes <jesse.barnes@intel.com>
Cc: jim liu <jim.liu@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Keith Packard <keithp@keithp.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-media@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Min He <min.he@intel.com>
Cc: Niu Bing <bing.niu@intel.com>
Cc: nouveau@lists.freedesktop.org
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Pei Zhang <pei.zhang@intel.com>
Cc: Ping Gao <ping.a.gao@intel.com>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Tina Zhang <tina.zhang@intel.com>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
@ 2021-01-15 18:15 ` Lee Jones
  2021-01-15 18:15 ` [PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-15 18:15 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Ben Skeggs, David Airlie, Daniel Vetter, dri-devel,
	nouveau

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand  * file mga_ioc32.c

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
index adf01ca9e035d..8ddf9b2325a42 100644
--- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
+++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
@@ -1,4 +1,4 @@
-/**
+/*
  * \file mga_ioc32.c
  *
  * 32-bit ioctl compatibility routines for the MGA DRM.
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
  2021-01-15 18:15 ` [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
@ 2021-01-15 18:15 ` Lee Jones
  2021-01-15 18:15 ` [PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()' Lee Jones
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-15 18:15 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Ben Skeggs, David Airlie, Daniel Vetter, dri-devel,
	nouveau

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’:
 drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
index 4f69e4c3dafde..84c5bf53fe967 100644
--- a/drivers/gpu/drm/nouveau/nouveau_svm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
@@ -807,7 +807,6 @@ nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct *mm,
 		 unsigned long addr, u64 *pfns, unsigned long npages)
 {
 	struct nouveau_pfnmap_args *args = nouveau_pfns_to_args(pfns);
-	int ret;
 
 	args->p.addr = addr;
 	args->p.size = npages << PAGE_SHIFT;
@@ -815,8 +814,8 @@ nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct *mm,
 	mutex_lock(&svmm->mutex);
 
 	svmm->vmm->vmm.object.client->super = true;
-	ret = nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) +
-				npages * sizeof(args->p.phys[0]), NULL);
+	nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) +
+			  npages * sizeof(args->p.phys[0]), NULL);
 	svmm->vmm->vmm.object.client->super = false;
 
 	mutex_unlock(&svmm->mutex);
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()'
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
  2021-01-15 18:15 ` [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
  2021-01-15 18:15 ` [PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones
@ 2021-01-15 18:15 ` Lee Jones
  2021-01-15 18:16 ` [PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
  4 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-15 18:15 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Ben Skeggs, David Airlie, Daniel Vetter, dri-devel,
	nouveau

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_bios.c: In function ‘nouveau_bios_init’:
 drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable]

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 7cc683b8dc7a6..e8c445eb11004 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
 	struct nvbios *bios = &drm->vbios;
-	struct pci_dev *pdev;
 	int ret;
 
 	/* only relevant for PCI devices */
 	if (!dev_is_pci(dev->dev))
 		return 0;
-	pdev = to_pci_dev(dev->dev);
 
 	if (!NVInitVBIOS(dev))
 		return -ENODEV;
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
                   ` (2 preceding siblings ...)
  2021-01-15 18:15 ` [PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()' Lee Jones
@ 2021-01-15 18:16 ` Lee Jones
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
  4 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-15 18:16 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Ben Skeggs, David Airlie, Daniel Vetter, dri-devel,
	nouveau

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl'
 drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in 'nouveau_compat_ioctl'
 drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'arg' not described in 'nouveau_compat_ioctl'

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
index 8ddf9b2325a42..2af3615c5205c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
+++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
@@ -38,7 +38,7 @@
 
 #include "nouveau_ioctl.h"
 
-/**
+/*
  * Called whenever a 32-bit process running under a 64-bit kernel
  * performs an ioctl on /dev/dri/card<n>.
  *
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
                   ` (3 preceding siblings ...)
  2021-01-15 18:16 ` [PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones
@ 2021-01-15 18:27 ` Zack Rusin
  2021-01-18  9:49   ` Daniel Vetter
  2021-01-18 14:54   ` Daniel Vetter
  4 siblings, 2 replies; 13+ messages in thread
From: Zack Rusin @ 2021-01-15 18:27 UTC (permalink / raw)
  To: Lee Jones
  Cc: David Airlie, nouveau, DRI Development, Eric Anholt,
	Jesse Barnes, Jan Safrata, Sumit Semwal, Gareth Hughes,
	Pei Zhang, Rob Clark, Min He, Linux-graphics-maintainer,
	Ben Skeggs, Dave Airlie, Niu Bing, linux-media, jim liu,
	Thomas Zimmermann, Roland Scheidegger, intel-gfx,
	linaro-mm-sig@lists.linaro.org


> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> 
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Thanks! For all the vmwgfx bits:
Reviewed-by: Zack Rusin <zackr@vmware.com>

z

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
@ 2021-01-18  9:49   ` Daniel Vetter
  2021-01-18 14:54   ` Daniel Vetter
  1 sibling, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2021-01-18  9:49 UTC (permalink / raw)
  To: Zack Rusin
  Cc: David Airlie, nouveau, DRI Development, Eric Anholt,
	Jesse Barnes, Jan Safrata, Lee Jones, Sumit Semwal,
	Gareth Hughes, Pei Zhang, Rob Clark, Min He,
	Linux-graphics-maintainer, Ben Skeggs, Dave Airlie, Niu Bing,
	linux-media, jim liu, Thomas Zimmermann, Roland Scheidegger,
	intel-gfx, linaro-mm-sig

On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> 
> > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> 
> Thanks! For all the vmwgfx bits:
> Reviewed-by: Zack Rusin <zackr@vmware.com>

Can you pls push them to drm-misc-next? I'm planning to go pull in all the
other patches later today that belong into drm-misc-next, but some patch
monkey help would be really great :-)

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
  2021-01-18  9:49   ` Daniel Vetter
@ 2021-01-18 14:54   ` Daniel Vetter
       [not found]     ` <YAWhDRkSOHbJ+2Le-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
       [not found]     ` <20210118150945.GE4903@dell>
  1 sibling, 2 replies; 13+ messages in thread
From: Daniel Vetter @ 2021-01-18 14:54 UTC (permalink / raw)
  To: Zack Rusin
  Cc: David Airlie, nouveau, DRI Development, Eric Anholt,
	Jesse Barnes, Jan Safrata, Lee Jones, Sumit Semwal,
	Gareth Hughes, Pei Zhang, Rob Clark, Min He,
	Linux-graphics-maintainer, Ben Skeggs, Dave Airlie, Niu Bing,
	linux-media, jim liu, Thomas Zimmermann, Roland Scheidegger,
	intel-gfx, linaro-mm-sig

On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> 
> > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> > 
> > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> 
> Thanks! For all the vmwgfx bits:
> Reviewed-by: Zack Rusin <zackr@vmware.com>

Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
(those generally go through other trees, pls holler if they're stuck).

Note that we have some build issue on some of the configs sfr uses, so drm
trees are still stuck on old versions in linux-next. Hopefully should get
resolved soon, the bugfix is in some subtree I've heard.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
       [not found]     ` <YAWhDRkSOHbJ+2Le-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
@ 2021-01-18 15:09       ` Lee Jones
  0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-18 15:09 UTC (permalink / raw)
  To: Zack Rusin, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Ben Skeggs,
	Christian König, Dave Airlie, David Airlie, DRI Development,
	Eddie Dong, Eric Anholt, Faith, Gareth Hughes,
	intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	intel-gvt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Jackie Li,
	Jani Nikula, Jan Safrata, Jesse Barnes, jim liu, Joonas Lahtinen,
	Keith Packard, Kevin Tian

On Mon, 18 Jan 2021, Daniel Vetter wrote:

> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > 
> > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > 
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > > 
> > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > 
> > Thanks! For all the vmwgfx bits:
> > Reviewed-by: Zack Rusin <zackr@vmware.com>
> 
> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> (those generally go through other trees, pls holler if they're stuck).

Thanks Daniel, you're a superstar!

So Zack will take the vmwgfx parts?  Despite providing a R-b?

> Note that we have some build issue on some of the configs sfr uses, so drm
> trees are still stuck on old versions in linux-next. Hopefully should get
> resolved soon, the bugfix is in some subtree I've heard.

No worries.  Thanks for letting me know.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
       [not found]     ` <20210118150945.GE4903@dell>
@ 2021-01-18 17:21       ` Daniel Vetter
       [not found]         ` <YAXDgmWMR9s4OgxN-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
       [not found]         ` <20210119082927.GJ4903@dell>
  0 siblings, 2 replies; 13+ messages in thread
From: Daniel Vetter @ 2021-01-18 17:21 UTC (permalink / raw)
  To: Lee Jones
  Cc: David Airlie, nouveau, DRI Development, Eric Anholt,
	Jesse Barnes, Jan Safrata, Sumit Semwal, Gareth Hughes,
	Pei Zhang, Rob Clark, Min He, Linux-graphics-maintainer,
	Ben Skeggs, Dave Airlie, Niu Bing, linux-media, jim liu,
	Roland Scheidegger, intel-gfx, linaro-mm-sig

On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> 
> > On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > > 
> > > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > > 
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > > 
> > > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > > 
> > > Thanks! For all the vmwgfx bits:
> > > Reviewed-by: Zack Rusin <zackr@vmware.com>
> > 
> > Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> > (those generally go through other trees, pls holler if they're stuck).
> 
> Thanks Daniel, you're a superstar!
> 
> So Zack will take the vmwgfx parts?  Despite providing a R-b?

I only merge stuff that's defacto abandoned already. Everything else I try
to offload to whomever actually cares :-)
-Daniel

> 
> > Note that we have some build issue on some of the configs sfr uses, so drm
> > trees are still stuck on old versions in linux-next. Hopefully should get
> > resolved soon, the bugfix is in some subtree I've heard.
> 
> No worries.  Thanks for letting me know.
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
       [not found]         ` <YAXDgmWMR9s4OgxN-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
@ 2021-01-19  8:29           ` Lee Jones
  0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-19  8:29 UTC (permalink / raw)
  To: Zack Rusin, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Ben Skeggs,
	Christian König, Dave Airlie, David Airlie, DRI Development,
	Eddie Dong, Eric Anholt, Faith, Gareth Hughes,
	intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	intel-gvt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Jackie Li,
	Jani Nikula, Jan Safrata, Jesse Barnes, jim liu, Joonas Lahtinen,
	Keith Packard, Kevin Tian

On Mon, 18 Jan 2021, Daniel Vetter wrote:

> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> > On Mon, 18 Jan 2021, Daniel Vetter wrote:
> > 
> > > On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > > > 
> > > > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > > > 
> > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > niggly little warnings.
> > > > > 
> > > > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > > > 
> > > > Thanks! For all the vmwgfx bits:
> > > > Reviewed-by: Zack Rusin <zackr@vmware.com>
> > > 
> > > Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> > > (those generally go through other trees, pls holler if they're stuck).
> > 
> > Thanks Daniel, you're a superstar!
> > 
> > So Zack will take the vmwgfx parts?  Despite providing a R-b?
> 
> I only merge stuff that's defacto abandoned already. Everything else I try
> to offload to whomever actually cares :-)

Understood.  Thanks for the explanation.

Hopefully Zack actually cares. :D

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
       [not found]         ` <20210119082927.GJ4903@dell>
@ 2021-01-19 19:27           ` Zack Rusin
  2021-01-20  8:05             ` Lee Jones
  0 siblings, 1 reply; 13+ messages in thread
From: Zack Rusin @ 2021-01-19 19:27 UTC (permalink / raw)
  To: Lee Jones
  Cc: David Airlie, nouveau, DRI Development, Eric Anholt,
	Jesse Barnes, Jan Safrata, Sumit Semwal, Gareth Hughes,
	Pei Zhang, Rob Clark, Min He, Linux-graphics-maintainer,
	Ben Skeggs, Dave Airlie, Niu Bing, linux-media, jim liu,
	Roland Scheidegger, intel-gfx, linaro-mm-sig



> On Jan 19, 2021, at 03:29, Lee Jones <lee.jones@linaro.org> wrote:
> 
> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> 
>> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
>>> On Mon, 18 Jan 2021, Daniel Vetter wrote:
>>> 
>>>> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
>>>>> 
>>>>>> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
>>>>>> 
>>>>>> This set is part of a larger effort attempting to clean-up W=1
>>>>>> kernel builds, which are currently overwhelmingly riddled with
>>>>>> niggly little warnings.
>>>>>> 
>>>>>> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
>>>>> 
>>>>> Thanks! For all the vmwgfx bits:
>>>>> Reviewed-by: Zack Rusin <zackr@vmware.com>
>>>> 
>>>> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
>>>> (those generally go through other trees, pls holler if they're stuck).
>>> 
>>> Thanks Daniel, you're a superstar!
>>> 
>>> So Zack will take the vmwgfx parts?  Despite providing a R-b?
>> 
>> I only merge stuff that's defacto abandoned already. Everything else I try
>> to offload to whomever actually cares :-)
> 
> Understood.  Thanks for the explanation.
> 
> Hopefully Zack actually cares. :D

hah, I do. I just pushed all of the changes to drm-misc-next. Let me know if I missed anything. Thanks!

z

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!
  2021-01-19 19:27           ` Zack Rusin
@ 2021-01-20  8:05             ` Lee Jones
  0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2021-01-20  8:05 UTC (permalink / raw)
  To: Zack Rusin
  Cc: David Airlie, nouveau, DRI Development, Eric Anholt,
	Jesse Barnes, Jan Safrata, Sumit Semwal, Gareth Hughes,
	Pei Zhang, Rob Clark, Min He, Linux-graphics-maintainer,
	Ben Skeggs, Dave Airlie, Niu Bing, linux-media, jim liu,
	Roland Scheidegger, intel-gfx, linaro-mm-sig

On Tue, 19 Jan 2021, Zack Rusin wrote:

> 
> 
> > On Jan 19, 2021, at 03:29, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > On Mon, 18 Jan 2021, Daniel Vetter wrote:
> > 
> >> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> >>> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> >>> 
> >>>> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> >>>>> 
> >>>>>> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> >>>>>> 
> >>>>>> This set is part of a larger effort attempting to clean-up W=1
> >>>>>> kernel builds, which are currently overwhelmingly riddled with
> >>>>>> niggly little warnings.
> >>>>>> 
> >>>>>> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> >>>>> 
> >>>>> Thanks! For all the vmwgfx bits:
> >>>>> Reviewed-by: Zack Rusin <zackr@vmware.com>
> >>>> 
> >>>> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> >>>> (those generally go through other trees, pls holler if they're stuck).
> >>> 
> >>> Thanks Daniel, you're a superstar!
> >>> 
> >>> So Zack will take the vmwgfx parts?  Despite providing a R-b?
> >> 
> >> I only merge stuff that's defacto abandoned already. Everything else I try
> >> to offload to whomever actually cares :-)
> > 
> > Understood.  Thanks for the explanation.
> > 
> > Hopefully Zack actually cares. :D
> 
> hah, I do. I just pushed all of the changes to drm-misc-next. Let me
> know if I missed anything. Thanks!

Perfect.  Thank you Zack.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-01-20  8:05 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones
2021-01-15 18:15 ` [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
2021-01-15 18:15 ` [PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones
2021-01-15 18:15 ` [PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()' Lee Jones
2021-01-15 18:16 ` [PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones
2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin
2021-01-18  9:49   ` Daniel Vetter
2021-01-18 14:54   ` Daniel Vetter
     [not found]     ` <YAWhDRkSOHbJ+2Le-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2021-01-18 15:09       ` Lee Jones
     [not found]     ` <20210118150945.GE4903@dell>
2021-01-18 17:21       ` Daniel Vetter
     [not found]         ` <YAXDgmWMR9s4OgxN-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2021-01-19  8:29           ` Lee Jones
     [not found]         ` <20210119082927.GJ4903@dell>
2021-01-19 19:27           ` Zack Rusin
2021-01-20  8:05             ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).