From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Emma Anholt" <emma@anholt.net>,
"David Airlie" <airlied@linux.ie>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Vishal Kulkarni" <vishal@chelsio.com>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Kentaro Takeda" <takedakn@nttdata.co.jp>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Petr Mladek" <pmladek@suse.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Leo Li" <sunpeng.li@amd.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Raju Rangoju" <rajur@chelsio.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Eryk Brol" <eryk.brol@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Nouveau] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation
Date: Wed, 19 Jan 2022 10:01:02 -0500 [thread overview]
Message-ID: <20220119100102.61f9bfde@gandalf.local.home> (raw)
In-Reply-To: <CAHp75Vf5QOD_UtDK8VbxNApEBuJvzUic0NkzDNmRo3Q7Ud+=qw@mail.gmail.com>
On Wed, 19 Jan 2022 11:15:08 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; }
>
>
>
> Perhaps keep it on 4 lines? Yes, yes/no is short, but if we add others
> (enable/disable) it will not be possible to keep on one line. And hence
> style will be broken among similar functions.
Agreed. Functions should always be of the normal format:
type func(params)
{
body;
}
Unless it is a stub function.
type func(params) { return 0; }
-- Steve
next prev parent reply other threads:[~2022-01-19 15:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 7:24 [Nouveau] [PATCH 0/3] lib/string_helpers: Add a few string helpers Lucas De Marchi
2022-01-19 7:24 ` [Nouveau] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Lucas De Marchi
2022-01-19 9:15 ` Andy Shevchenko
2022-01-19 15:01 ` Steven Rostedt [this message]
2022-01-19 16:37 ` David Laight
2022-01-19 16:38 ` David Laight
2022-01-19 19:22 ` Andy Shevchenko
2022-01-19 20:58 ` Steven Rostedt
2022-01-19 22:25 ` David Laight
2022-01-19 9:18 ` Sakari Ailus
2022-01-19 15:06 ` Steven Rostedt
2022-01-19 19:25 ` Andy Shevchenko
2022-01-19 21:00 ` Steven Rostedt
2022-01-19 21:04 ` Andy Shevchenko
2022-01-21 1:37 ` Joe Perches
2022-01-19 20:43 ` [Nouveau] [Intel-gfx] " Lucas De Marchi
2022-01-19 7:24 ` [Nouveau] [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d] Lucas De Marchi
2022-01-19 9:20 ` Andy Shevchenko
2022-01-19 9:42 ` Lucas De Marchi
2022-01-19 7:24 ` [Nouveau] [PATCH 3/3] drm: Convert open yes/no strings to yesno() Lucas De Marchi
2022-01-19 19:30 ` Andy Shevchenko
2022-01-26 9:05 ` Lucas De Marchi
2022-01-19 8:02 ` [Nouveau] [PATCH 0/3] lib/string_helpers: Add a few string helpers Jani Nikula
2022-01-19 9:28 ` Andy Shevchenko
2022-01-19 13:18 ` Petr Mladek
2022-01-19 14:16 ` Jani Nikula
2022-01-19 16:15 ` Daniel Vetter
2022-01-19 20:53 ` [Nouveau] [Intel-gfx] " Lucas De Marchi
2022-01-19 21:07 ` Andy Shevchenko
2022-01-20 8:38 ` [Nouveau] " Petr Mladek
2022-01-20 9:12 ` David Laight
2022-01-20 9:12 ` Jani Nikula
2022-01-20 10:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119100102.61f9bfde@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eryk.brol@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lucas.demarchi@intel.com \
--cc=mikita.lipski@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=pmladek@suse.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rajur@chelsio.com \
--cc=rodrigo.vivi@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sunpeng.li@amd.com \
--cc=takedakn@nttdata.co.jp \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).