From: Jani Nikula <jani.nikula@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: "Emma Anholt" <emma@anholt.net>,
"David Airlie" <airlied@linux.ie>,
nouveau@lists.freedesktop.org,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Vishal Kulkarni" <vishal@chelsio.com>,
"Francis Laniel" <laniel_francis@privacyrequired.com>,
"Kentaro Takeda" <takedakn@nttdata.co.jp>,
"Mikita Lipski" <mikita.lipski@amd.com>,
amd-gfx@lists.freedesktop.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Leo Li" <sunpeng.li@amd.com>,
intel-gfx@lists.freedesktop.org,
"Raju Rangoju" <rajur@chelsio.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Eryk Brol" <eryk.brol@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
linux-security-module@vger.kernel.org,
"Daniel Vetter" <daniel@ffwll.ch>,
netdev@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Nouveau] [PATCH 0/3] lib/string_helpers: Add a few string helpers
Date: Thu, 20 Jan 2022 11:12:27 +0200 [thread overview]
Message-ID: <8735libwjo.fsf@intel.com> (raw)
In-Reply-To: <YekfbKMjOP9ecc5v@alley>
On Thu, 20 Jan 2022, Petr Mladek <pmladek@suse.com> wrote:
> On Wed 2022-01-19 16:16:12, Jani Nikula wrote:
>> On Wed, 19 Jan 2022, Petr Mladek <pmladek@suse.com> wrote:
>> > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote:
>> >> d. This doesn't bring onoff() helper as there are some places in the
>> >> kernel with onoff as variable - another name is probably needed for
>> >> this function in order not to shadow the variable, or those variables
>> >> could be renamed. Or if people wanting <someprefix>
>> >> try to find a short one
>> >
>> > I would call it str_on_off().
>> >
>> > And I would actually suggest to use the same style also for
>> > the other helpers.
>> >
>> > The "str_" prefix would make it clear that it is something with
>> > string. There are other <prefix>_on_off() that affect some
>> > functionality, e.g. mute_led_on_off(), e1000_vlan_filter_on_off().
>> >
>> > The dash '_' would significantly help to parse the name. yesno() and
>> > onoff() are nicely short and kind of acceptable. But "enabledisable()"
>> > is a puzzle.
>> >
>> > IMHO, str_yes_no(), str_on_off(), str_enable_disable() are a good
>> > compromise.
>> >
>> > The main motivation should be code readability. You write the
>> > code once. But many people will read it many times. Open coding
>> > is sometimes better than misleading macro names.
>> >
>> > That said, I do not want to block this patchset. If others like
>> > it... ;-)
>>
>> I don't mind the names either way. Adding the prefix and dashes is
>> helpful in that it's possible to add the functions first and convert
>> users at leisure, though with a bunch of churn, while using names that
>> collide with existing ones requires the changes to happen in one go.
>
> It is also possible to support both notations at the beginning.
> And convert the existing users in the 2nd step.
>
>> What I do mind is grinding this series to a halt once again. I sent a
>> handful of versions of this three years ago, with inconclusive
>> bikeshedding back and forth, eventually threw my hands up in disgust,
>> and walked away.
>
> Yeah, and I am sorry for bikeshedding. Honestly, I do not know what is
> better. This is why I do not want to block this series when others
> like this.
>
> My main motivation is to point out that:
>
> enabledisable(enable)
>
> might be, for some people, more eye bleeding than
>
> enable ? "enable" : "disable"
>
>
> The problem is not that visible with yesno() and onoff(). But as you said,
> onoff() confliscts with variable names. And enabledisable() sucks.
> As a result, there is a non-trivial risk of two mass changes:
My point is, in the past three years we could have churned through more
than two mass renames just fine, if needed, *if* we had just managed to
merge something for a start!
BR,
Jani.
>
> now:
>
> - contition ? "yes" : "no"
> + yesno(condition)
>
> a few moths later:
>
> - yesno(condition)
> + str_yes_no(condition)
>
>
> Best Regards,
> Petr
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-01-20 9:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 7:24 [Nouveau] [PATCH 0/3] lib/string_helpers: Add a few string helpers Lucas De Marchi
2022-01-19 7:24 ` [Nouveau] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Lucas De Marchi
2022-01-19 9:15 ` Andy Shevchenko
2022-01-19 15:01 ` Steven Rostedt
2022-01-19 16:37 ` David Laight
2022-01-19 16:38 ` David Laight
2022-01-19 19:22 ` Andy Shevchenko
2022-01-19 20:58 ` Steven Rostedt
2022-01-19 22:25 ` David Laight
2022-01-19 9:18 ` Sakari Ailus
2022-01-19 15:06 ` Steven Rostedt
2022-01-19 19:25 ` Andy Shevchenko
2022-01-19 21:00 ` Steven Rostedt
2022-01-19 21:04 ` Andy Shevchenko
2022-01-21 1:37 ` Joe Perches
2022-01-19 20:43 ` [Nouveau] [Intel-gfx] " Lucas De Marchi
2022-01-19 7:24 ` [Nouveau] [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d] Lucas De Marchi
2022-01-19 9:20 ` Andy Shevchenko
2022-01-19 9:42 ` Lucas De Marchi
2022-01-19 7:24 ` [Nouveau] [PATCH 3/3] drm: Convert open yes/no strings to yesno() Lucas De Marchi
2022-01-19 19:30 ` Andy Shevchenko
2022-01-26 9:05 ` Lucas De Marchi
2022-01-19 8:02 ` [Nouveau] [PATCH 0/3] lib/string_helpers: Add a few string helpers Jani Nikula
2022-01-19 9:28 ` Andy Shevchenko
2022-01-19 13:18 ` Petr Mladek
2022-01-19 14:16 ` Jani Nikula
2022-01-19 16:15 ` Daniel Vetter
2022-01-19 20:53 ` [Nouveau] [Intel-gfx] " Lucas De Marchi
2022-01-19 21:07 ` Andy Shevchenko
2022-01-20 8:38 ` [Nouveau] " Petr Mladek
2022-01-20 9:12 ` David Laight
2022-01-20 9:12 ` Jani Nikula [this message]
2022-01-20 10:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735libwjo.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eryk.brol@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lucas.demarchi@intel.com \
--cc=mikita.lipski@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=pmladek@suse.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rajur@chelsio.com \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sunpeng.li@amd.com \
--cc=takedakn@nttdata.co.jp \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).