From: Lyude Paul <lyude@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>,
intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers
Date: Tue, 05 Oct 2021 16:26:28 -0400 [thread overview]
Message-ID: <2b04c75841f4c1661c242a3371b12d52bb0573ef.camel@redhat.com> (raw)
In-Reply-To: <a6ea3fa3-fbbd-f5e8-54ab-3929ed9f7294@redhat.com>
On Sat, 2021-10-02 at 11:14 +0200, Hans de Goede wrote:
> Hi Lyude,
>
> On 10/2/21 12:53 AM, Lyude Paul wrote:
> > When I originally moved all of the VESA backlight code in i915 into DRM
> > helpers, one of the things I didn't have the hardware or time for
> > testing was machines that used a combination of PWM and DPCD in order to
> > control their backlights. This has since then caused some breakages and
> > resulted in us disabling DPCD backlight support on such machines. This
> > works fine, unless you have a machine that actually needs this
> > functionality for backlight controls to work at all. Additionally, we
> > will need to support PWM for when we start adding support for VESA's
> > product (as in the product of multiplication) control mode for better
> > brightness ranges.
> >
> > So - let's finally finish up implementing basic support for these types
> > of backlights to solve these problems in our DP helpers, along with
> > implementing support for this in i915. And since digging into this issue
> > solved the last questions we really had about probing backlights in i915
> > for the most part, let's update some of the comments around that as
> > well!
>
> Backlight control is a topic which I'm reasonably familiar with,
> do you want me to review this series for you ?
Possibly, although I definitely want to make sure that someone from Intel gets
a chance to review this as well. I'm more curious if you might happen to have
any systems that would be able to test this.
>
> Regards,
>
> Hans
>
>
>
> >
> > Changes:
> > * Fixup docs
> > * Add patch to stop us from breaking nouveau
> >
> > Lyude Paul (4):
> > drm/i915: Add support for panels with VESA backlights with PWM
> > enable/disable
> > drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux
> > enable/brightness
> > drm/dp, drm/i915: Add support for VESA backlights using PWM for
> > brightness control
> > drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs()
> >
> > drivers/gpu/drm/drm_dp_helper.c | 75 +++++++++++------
> > .../drm/i915/display/intel_dp_aux_backlight.c | 80 ++++++++++++++-----
> > drivers/gpu/drm/nouveau/nouveau_backlight.c | 5 +-
> > include/drm/drm_dp_helper.h | 7 +-
> > 4 files changed, 122 insertions(+), 45 deletions(-)
> >
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
next prev parent reply other threads:[~2021-10-05 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 22:53 [Nouveau] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers Lyude Paul
2021-10-01 22:53 ` [Nouveau] [PATCH v2 1/4] drm/i915: Add support for panels with VESA backlights with PWM enable/disable Lyude Paul
2021-10-01 22:53 ` [Nouveau] [PATCH v2 2/4] drm/nouveau/kms/nv50-: Explicitly check DPCD backlights for aux enable/brightness Lyude Paul
2021-10-01 22:53 ` [Nouveau] [PATCH v2 3/4] drm/dp, drm/i915: Add support for VESA backlights using PWM for brightness control Lyude Paul
2021-10-01 22:53 ` [Nouveau] [PATCH v2 4/4] drm/i915: Clarify probing order in intel_dp_aux_init_backlight_funcs() Lyude Paul
2021-10-02 9:14 ` [Nouveau] [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers Hans de Goede
2021-10-05 20:26 ` Lyude Paul [this message]
2021-10-07 9:54 ` Hans de Goede
2021-10-07 10:07 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b04c75841f4c1661c242a3371b12d52bb0573ef.camel@redhat.com \
--to=lyude@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).