[Nouveau] [PATCH] drm/nouveau/iccsense: do not use assignment in if condition

* [Nouveau] [PATCH] drm/nouveau/iccsense: do not use assignment in if condition
       [not found] <20230710095957.77430-1-xujianghui@cdjrlc.com>
@ 2023-07-10 10:01 ` sunran001
  0 siblings, 0 replies; only message in thread
From: sunran001 @ 2023-07-10 10:01 UTC (permalink / raw)
  To: airlied, daniel; +Cc: nouveau, linux-kernel, dri-devel

checkpatch.pl does not like assignment in if condition

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
index 8f0ccd3664eb..2428f3d6e477 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -322,7 +322,8 @@ int
  nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type 
type, int inst,
             struct nvkm_iccsense **iccsense)
  {
-    if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
+    *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
+    if (!*iccsense)
          return -ENOMEM;
      INIT_LIST_HEAD(&(*iccsense)->sensors);
      INIT_LIST_HEAD(&(*iccsense)->rails);

^ permalink raw reply related	[flat|nested] only message in thread