* [Nouveau] [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable
@ 2021-03-17 9:35 ChunyouTang
2021-03-24 23:28 ` Ben Skeggs
0 siblings, 1 reply; 2+ messages in thread
From: ChunyouTang @ 2021-03-17 9:35 UTC (permalink / raw)
To: bskeggs, airlied, daniel, lyude
Cc: nouveau, tangchunyou, linux-kernel, dri-devel
From: tangchunyou <tangchunyou@yulong.com>
disable,delete disable and return 0
Signed-off-by: tangchunyou <tangchunyou@yulong.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
index fb90d47..a9cdf24 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
@@ -32,7 +32,6 @@
struct nvkm_device *device = init->subdev.device;
u32 r001540 = nvkm_rd32(device, 0x001540);
u32 r00154c = nvkm_rd32(device, 0x00154c);
- u64 disable = 0;
if (!(r001540 & 0x40000000)) {
nvkm_subdev_disable(device, NVKM_ENGINE_MSPDEC, 0);
@@ -48,7 +47,7 @@
if (!(r00154c & 0x00000200))
nvkm_subdev_disable(device, NVKM_ENGINE_CE, 0);
- return disable;
+ return 0;
}
static const struct nvkm_devinit_func
--
1.9.1
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable
2021-03-17 9:35 [Nouveau] [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable ChunyouTang
@ 2021-03-24 23:28 ` Ben Skeggs
0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2021-03-24 23:28 UTC (permalink / raw)
To: ChunyouTang
Cc: Dave Airlie, ML nouveau, LKML, ML dri-devel, Ben Skeggs,
Daniel Vetter, tangchunyou
On Wed, 17 Mar 2021 at 19:51, ChunyouTang <tangchunyou@163.com> wrote:
>
> From: tangchunyou <tangchunyou@yulong.com>
>
> disable,delete disable and return 0
>
> Signed-off-by: tangchunyou <tangchunyou@yulong.com>
Thanks!
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
> index fb90d47..a9cdf24 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c
> @@ -32,7 +32,6 @@
> struct nvkm_device *device = init->subdev.device;
> u32 r001540 = nvkm_rd32(device, 0x001540);
> u32 r00154c = nvkm_rd32(device, 0x00154c);
> - u64 disable = 0;
>
> if (!(r001540 & 0x40000000)) {
> nvkm_subdev_disable(device, NVKM_ENGINE_MSPDEC, 0);
> @@ -48,7 +47,7 @@
> if (!(r00154c & 0x00000200))
> nvkm_subdev_disable(device, NVKM_ENGINE_CE, 0);
>
> - return disable;
> + return 0;
> }
>
> static const struct nvkm_devinit_func
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 23:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 9:35 [Nouveau] [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable ChunyouTang
2021-03-24 23:28 ` Ben Skeggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).