* [PATCH] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve
@ 2020-11-26 13:11 Christian König
[not found] ` <20201126131141.15060-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Christian König @ 2020-11-26 13:11 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: airlied-cv59FeDIM0c
This wasn't initialized for pre NV50 hardware.
Signed-off-by: Christian König <christian.koenig@amd.com>
Reported-and-Tested-by: Mark Hounschell <dmarkh@cfl.rr.com>
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 7aa4286784ae..42292b3a6eb9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1135,8 +1135,8 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_resource *reg)
}
reg->bus.offset = handle;
- ret = 0;
}
+ ret = 0;
break;
default:
ret = -EINVAL;
--
2.25.1
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve
[not found] ` <20201126131141.15060-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
@ 2020-11-26 14:39 ` Karol Herbst
0 siblings, 0 replies; 2+ messages in thread
From: Karol Herbst @ 2020-11-26 14:39 UTC (permalink / raw)
To: Christian König; +Cc: David Airlie, nouveau, dri-devel
Reviewed-by: Karol Herbst <kherbst@redhat.com>
On Thu, Nov 26, 2020 at 2:11 PM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> This wasn't initialized for pre NV50 hardware.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reported-and-Tested-by: Mark Hounschell <dmarkh@cfl.rr.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 7aa4286784ae..42292b3a6eb9 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1135,8 +1135,8 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_resource *reg)
> }
>
> reg->bus.offset = handle;
> - ret = 0;
> }
> + ret = 0;
> break;
> default:
> ret = -EINVAL;
> --
> 2.25.1
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-26 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 13:11 [PATCH] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve Christian König
[not found] ` <20201126131141.15060-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2020-11-26 14:39 ` Karol Herbst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).